Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update rainbowkit recommendation #6087

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Conversation

bakoushin
Copy link
Contributor

Description

Update the links since Valora is now supported in rainbowkit and the rainbowkit-celo is sunset.

Test plan

Visual assessment

Related issues

Fixes #5983

Backwards compatibility

NA

Network scalability

NA

@bakoushin bakoushin changed the title chore(docs): update rainbowkit mention chore(docs): update rainbowkit recommendation Sep 24, 2024
Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🚀

Additionally we could/should probably link to https://github.com/valora-inc/dapp-list/blob/main/docs/adding-new-dapps.md#showing-valora-as-a-preferred-wallet which shows how to make sure Valora is part of the preferred wallets displayed.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.73%. Comparing base (b39dbf8) to head (e217969).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6087      +/-   ##
==========================================
- Coverage   88.74%   88.73%   -0.01%     
==========================================
  Files         727      727              
  Lines       30772    30772              
  Branches     5614     5614              
==========================================
- Hits        27309    27306       -3     
+ Misses       3420     3268     -152     
- Partials       43      198     +155     

see 67 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b39dbf8...e217969. Read the comment docs.

@bakoushin bakoushin added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit cf5ff64 Sep 24, 2024
16 checks passed
@bakoushin bakoushin deleted the alex/rainbowkit-docs branch September 24, 2024 16:01
@bakoushin
Copy link
Contributor Author

@jeanregisser thanks for the suggestion! addressed in valora-inc/dapp-list#669

Additionally we could/should probably link to https://github.com/valora-inc/dapp-list/blob/main/docs/adding-new-dapps.md#showing-valora-as-a-preferred-wallet which shows how to make sure Valora is part of the preferred wallets displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove @celo/rainbowkit recommendation
2 participants