Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): re-enable home feed e2e test #6158

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

bakoushin
Copy link
Contributor

Description

Reverts #6101 as the GraphQL endpoint for Alfajores has been fixed.

Context: https://valora-app.slack.com/archives/C01AEKH9XGX/p1728460043801219?thread_ts=1727801385.833739&cid=C01AEKH9XGX

Test plan

CI succeeds

Related issues

NA

Backwards compatibility

NA

Network scalability

NA

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.76%. Comparing base (76f1605) to head (b8b9de0).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6158      +/-   ##
==========================================
- Coverage   88.76%   88.76%   -0.01%     
==========================================
  Files         727      727              
  Lines       30776    30776              
  Branches     5627     5324     -303     
==========================================
- Hits        27319    27318       -1     
- Misses       3259     3415     +156     
+ Partials      198       43     -155     

see 67 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f1605...b8b9de0. Read the comment docs.

@bakoushin bakoushin marked this pull request as ready for review October 16, 2024 14:23
Copy link
Contributor

@sviderock sviderock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh cool, so they implemented the old API we were using?

@bakoushin
Copy link
Contributor Author

@jeanregisser yes, exactly!

@bakoushin bakoushin added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 59d75a7 Oct 16, 2024
15 checks passed
@bakoushin bakoushin deleted the alex/re-enable-homefeed-e2e-test branch October 16, 2024 15:12
bakoushin added a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants