chore(TransactionFeedV2): Merge old stand by transactions that are out of scope of pagination #6185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6185 +/- ##
==========================================
- Coverage 88.90% 88.89% -0.01%
==========================================
Files 733 733
Lines 31142 31144 +2
Branches 5717 5414 -303
==========================================
Hits 27686 27686
- Misses 3259 3415 +156
+ Partials 197 43 -154
... and 67 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
jeanregisser
approved these changes
Oct 24, 2024
Comment on lines
625
to
626
| await waitFor(() => { | ||
| expect(tree.getByTestId('TransactionList')).toBeVisible() |
There was a problem hiding this comment.
Could we wait for just that line instead of the whole thing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the merging process of pagination data with stand by transactions. Previously, there were still some stand by transactions that didn't get merged, specifically those that are older than the last transaction from pagination. This PR fixes that by merging all the stand by transactions that are "out of scope" of pagination at the very end of the feed.
Test plan
Added test that checks proper merging for old stand by transactions
Related issues
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: