-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.10.11 #2021
Release v0.10.11 #2021
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a discussion around the two new packages. I think it would be best not to have new packages and instead discriminate inside each package.
autonomy/chain/mint.py
Outdated
@@ -89,6 +91,7 @@ def wait_for_component_to_mint( | |||
deadline = datetime.datetime.now() + datetime.timedelta(seconds=timeout) | |||
while datetime.datetime.now() < deadline: | |||
token_id = token_retriever() | |||
print(token_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
autonomy/chain/mint.py
Outdated
@@ -185,6 +188,7 @@ def mint_service( # pylint: disable=too-many-arguments | |||
threshold: int, | |||
owner: Optional[str] = None, | |||
timeout: Optional[float] = None, | |||
l2: bool = False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't make this a flag. The rule is: Ethereum -> standard registry, all other networks -> l2 registry. No need for user having to know this.
@@ -159,6 +159,7 @@ def mint_component( # pylint: disable=too-many-arguments, too-many-locals | |||
owner: Optional[str] = None, | |||
password: Optional[str] = None, | |||
skip_hash_check: bool = False, | |||
skip_dependencies_check: bool = False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also be set by the framework so user doesn't have to. Rule: if l2 (network other than ethereum) don't need it ever. If Network ethereum, give user choice.
docs/api/cli/mint.md
Outdated
@@ -194,6 +199,11 @@ Mint an agent. | |||
required=True, | |||
help="Threshold for the minimum numbers required to run the service", | |||
) | |||
@click.option( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above; should be inferred from network selection. Not something user needs to bother with
L1_CHAINS = ( | ||
1, | ||
5, | ||
31337, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ethereum, goerli and hardhat node
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2021 +/- ##
==========================================
- Coverage 94.38% 94.34% -0.05%
==========================================
Files 240 240
Lines 14435 14491 +56
==========================================
+ Hits 13625 13671 +46
- Misses 810 820 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Release summary
Version number: v0.10.11
Release details
Autonomy:
Checklist
Put an
x
in the boxes that apply.main
branch (left side), fromdevelop
tox
)HISTORY.md
for this release__init__.py
file.pip install project-name==<version-number> --index-url https://test.pypi.org/simple --force --no-cache-dir --no-deps
command will work:
pip install project-name-template==<version_number> --force --no-cache-dir --no-deps
v${VERSION_NUMVER}
(e.g.v0.1.2
)Further comments
Write here any other comment about the release, if any.