Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.10.11 #2021

Merged
merged 26 commits into from
Aug 9, 2023
Merged

Release v0.10.11 #2021

merged 26 commits into from
Aug 9, 2023

Conversation

angrybayblade
Copy link
Contributor

@angrybayblade angrybayblade commented Aug 8, 2023

Release summary

Version number: v0.10.11

Release details

Autonomy:

  • Adds support for minting services on layer 2 chains
  • Adds support for skipping dependency checks when minting components

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side), from develop
  • I've updated the dependencies versions to the latest, wherever is possible.
  • Lint and unit tests pass locally (please run tests also manually, not only with tox)
  • I built the documentation and updated it with the latest changes
  • I've added an item in HISTORY.md for this release
  • I bumped the version number in the __init__.py file.
  • I published the latest version on TestPyPI and checked that the following command work:
    pip install project-name==<version-number> --index-url https://test.pypi.org/simple --force --no-cache-dir --no-deps
  • After merging the PR, I'll publish the build also on PyPI. Then, I'll make sure the following
    command will work:
    pip install project-name-template==<version_number> --force --no-cache-dir --no-deps
  • After merging the PR, I'll tag the repo with v${VERSION_NUMVER} (e.g. v0.1.2)

Further comments

Write here any other comment about the release, if any.

Copy link
Contributor

@DavidMinarsch DavidMinarsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a discussion around the two new packages. I think it would be best not to have new packages and instead discriminate inside each package.

@@ -89,6 +91,7 @@ def wait_for_component_to_mint(
deadline = datetime.datetime.now() + datetime.timedelta(seconds=timeout)
while datetime.datetime.now() < deadline:
token_id = token_retriever()
print(token_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@@ -185,6 +188,7 @@ def mint_service( # pylint: disable=too-many-arguments
threshold: int,
owner: Optional[str] = None,
timeout: Optional[float] = None,
l2: bool = False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't make this a flag. The rule is: Ethereum -> standard registry, all other networks -> l2 registry. No need for user having to know this.

@@ -159,6 +159,7 @@ def mint_component( # pylint: disable=too-many-arguments, too-many-locals
owner: Optional[str] = None,
password: Optional[str] = None,
skip_hash_check: bool = False,
skip_dependencies_check: bool = False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be set by the framework so user doesn't have to. Rule: if l2 (network other than ethereum) don't need it ever. If Network ethereum, give user choice.

@@ -194,6 +199,11 @@ Mint an agent.
required=True,
help="Threshold for the minimum numbers required to run the service",
)
@click.option(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above; should be inferred from network selection. Not something user needs to bother with

Comment on lines +36 to +40
L1_CHAINS = (
1,
5,
31337,
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ethereum, goerli and hardhat node

@angrybayblade angrybayblade changed the title [WIP] Release v0.10.11 Release v0.10.11 Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 89.65% and project coverage change: -0.05% ⚠️

Comparison is base (db5d833) 94.38% compared to head (a195eb5) 94.34%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2021      +/-   ##
==========================================
- Coverage   94.38%   94.34%   -0.05%     
==========================================
  Files         240      240              
  Lines       14435    14491      +56     
==========================================
+ Hits        13625    13671      +46     
- Misses        810      820      +10     
Flag Coverage Δ
unittests 94.34% <89.65%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...kages/valory/contracts/service_manager/contract.py 83.58% <84.00%> (-0.51%) ⬇️
...ages/valory/contracts/service_registry/contract.py 94.95% <84.00%> (-3.03%) ⬇️
autonomy/chain/mint.py 97.97% <93.75%> (-0.91%) ⬇️
autonomy/__version__.py 100.00% <100.00%> (ø)
autonomy/chain/constants.py 100.00% <100.00%> (ø)
autonomy/cli/helpers/chain.py 94.47% <100.00%> (+0.06%) ⬆️
autonomy/cli/mint.py 100.00% <100.00%> (ø)
autonomy/constants.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@angrybayblade angrybayblade merged commit 27c6ad6 into main Aug 9, 2023
18 of 24 checks passed
@DavidMinarsch DavidMinarsch deleted the release/v0.10.11 branch August 10, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants