Cookiejar implementation. #526
Conversation
…d CookieJar structure helping user to collect cookies easily without using external packages.
|
I think if we're going to add a CookieJar we should do it right and follow the spec. So:
|
…y URI. Added function to release cookies by expiration. Added function to copy cookie slices
…ged getFrom and dumpTo functions
cookiejar.go
Outdated
| c := searchCookieByKeyAndPath(key, path, cookies) | ||
| if c == nil { | ||
| c = AcquireCookie() | ||
| created = true |
There was a problem hiding this comment.
Better do the expired check here first so you don't acquire and release a cookie immediately if it didn't exist already.
There was a problem hiding this comment.
I don't see any other way to do this.
If I do the expiration checking at cookiejar.go:197 first I need to call ParseBytes and the code will be repeated in the case c == nil and c != nil. I prefer to keep it like this unless you see any other way to do that.
There was a problem hiding this comment.
Yes you are right, I forgot that you have to somehow parse the cookie first to get the expiration date. Doing that in a stack allocate cookie value would be possible for example but it would result in messier code.
cookiejar.go
Outdated
| cj.m.Lock() | ||
| { | ||
| if cj.hostCookies == nil { | ||
| cj.hostCookies = make(map[string][]*Cookie) |
There was a problem hiding this comment.
Here you can just do return. No need to allocate anything.
There was a problem hiding this comment.
Just make sure you do defer cj.m.Unlock() instead of doing this at the end of the function.
I myself always prefer to defer Unlocks as its much easier to follow the code. Also defer is basically free these days so no worry about performance.
cookiejar.go
Outdated
| c := searchCookieByKeyAndPath(key, path, cookies) | ||
| if c == nil { | ||
| c = AcquireCookie() | ||
| created = true |
There was a problem hiding this comment.
Yes you are right, I forgot that you have to somehow parse the cookie first to get the expiration date. Doing that in a stack allocate cookie value would be possible for example but it would result in messier code.
erikdubbelboer
force-pushed
the
master
branch
from
057b6d7
to
fbe6a2d
Compare
|
Any progress? |
|
bump |
Hello,
This commit tries to implement a basic CookieJar structure to handle Cookies easily without using external packages.