Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop descriptive names from treps #368

Merged
merged 1 commit into from
Jun 4, 2020
Merged

drop descriptive names from treps #368

merged 1 commit into from
Jun 4, 2020

Conversation

siebrenf
Copy link
Member

@siebrenf siebrenf commented Jun 4, 2020

fix #349

@siebrenf
Copy link
Member Author

siebrenf commented Jun 4, 2020

descriptive names are now taken from samples, instead of treps. Am I doing this right @Maarten-vd-Sande?

Maarten-vd-Sande
Maarten-vd-Sande approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@Maarten-vd-Sande Maarten-vd-Sande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. If it doesn't work properly we'll find out soon enough 😋

@siebrenf siebrenf merged commit 69b1c66 into develop Jun 4, 2020
@siebrenf siebrenf deleted the clean_treps branch June 4, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maarten-vd-Sande Maarten-vd-Sande Maarten-vd-Sande approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siebrenf @Maarten-vd-Sande