Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clone bytes #640

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

ifplusor
Copy link
Collaborator

What has changed and how does it work?

refactor cloning bytes.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Signed-off-by: James Yean <ywhjames@hotmail.com>
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #640 (31a6d3b) into main (ee76217) will decrease coverage by 5.79%.
Report is 102 commits behind head on main.
The diff coverage is 3.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #640      +/-   ##
==========================================
- Coverage   57.07%   51.28%   -5.79%     
==========================================
  Files         190      260      +70     
  Lines       15191    19521    +4330     
==========================================
+ Hits         8670    10012    +1342     
- Misses       5884     8695    +2811     
- Partials      637      814     +177     
Flag Coverage Δ
unittests 51.28% <3.63%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/errors/app.go 30.90% <ø> (ø)
lib/bytes/clone_go119.go 0.00% <ø> (ø)
lib/bytes/escape.go 54.46% <ø> (ø)
lib/bytes/io.go 0.00% <ø> (ø)
lib/bytes/parse.go 7.14% <ø> (ø)
lib/bytes/unsafe.go 100.00% <ø> (ø)
lib/bytes/utf8.go 11.11% <ø> (ø)
lib/json/path/parse.go 49.41% <ø> (ø)
lib/json/path/path.go 0.00% <ø> (ø)
lib/json/path/segment.go 0.00% <ø> (ø)
... and 31 more

... and 393 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3dd7d0...31a6d3b. Read the comment docs.

@ifplusor ifplusor merged commit 5712f51 into vanus-labs:main Oct 18, 2023
3 of 6 checks passed
@ifplusor ifplusor deleted the refactor-bytes-clone branch October 18, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants