Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade DeepCell to 0.9.2 and set up CI/CD workflows #14

Merged
merged 54 commits into from
Aug 12, 2021
Merged

Conversation

willgraf
Copy link
Contributor

@willgraf willgraf commented Aug 2, 2021

@willgraf willgraf added the fix Fixes a bug label Aug 2, 2021
@willgraf willgraf changed the title Upgrade DeepCell to 0.9.1 Upgrade DeepCell to 0.9.1 and set up CI/CD workflows Aug 11, 2021
@willgraf willgraf changed the title Upgrade DeepCell to 0.9.1 and set up CI/CD workflows Upgrade DeepCell to 0.9.2 and set up CI/CD workflows Aug 11, 2021
Copy link
Contributor

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! I was able to get it working purely by reading documentation, and the input sanitization provided great error messages for the stuff I mistyped initially.

Also did some testing of other bad args intentionally, failed gracefully for all of them.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
deepcell_applications/io.py Show resolved Hide resolved
run_app.py Show resolved Hide resolved
Copy link
Contributor

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, a couple additional suggestions for wording in the readme, feel free to ignore if you don't like them.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Noah F. Greenwald <noahfgreenwald@gmail.com>
@willgraf willgraf merged commit f65bb8e into master Aug 12, 2021
@willgraf willgraf deleted the deepcell-0.9.1 branch August 12, 2021 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fix Fixes a bug
Projects
None yet
2 participants