Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI testing against dev branches of deepcell-toolbox and deepcell-tracking #636

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

rossbar
Copy link
Contributor

@rossbar rossbar commented Jan 4, 2023

This should help catch incompatibilities between unreleased versions of libraries in the deepcell ecosystem.

What

  • Code remains unaffected - this PR is just dedicated to bolstering testing infrastructure

Why

  • The deepcell- libraries are interdependent: deepcell-tf depends on deepcell-tracking and deepcell-toolbox. If there is a change in one of these dependencies, there is no way to tell in the automated test running whether this will break something in deepcell-tf until the underlying libraries are released. Testing against the dev branches will catch potential issues sooner, at the expense of being noisier and reducing test specificity (failures can originate from either deepcell-tf or the dependencies). Overall however I think this should improve the ability to things consistent across libraries.

Copy link
Member

@msschwartz21 msschwartz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to confirm that this will test against latest commit to master (e.g. not other branches that might still be wip) for each each of the deepcell-* repos?

I like this pattern and we should consider adding the same enhancement to the deepcell-tracking since it is dependent on deepcell-toolbox.

.github/workflows/tests.yaml Show resolved Hide resolved
@rossbar
Copy link
Contributor Author

rossbar commented Jan 5, 2023

Just wanted to confirm that this will test against latest commit to master (e.g. not other branches that might still be wip) for each each of the deepcell-* repos?

Correct - this sets up tests against deepcell-tracking@master and deepcell-toolbox@master. This means there may have to be some manual retriggering after PRs are merged to master in the dependencies, but it's better than not testing at all!

I like this pattern and we should consider adding the same enhancement to the deepcell-tracking since it is dependent on deepcell-toolbox.

Agreed!

Test against the development branches of the deepcell- dependencies:
deepcell-toolbox and deepcell-tracking.

This should help catch incompatibilities between unreleased versions of
libraries in the deepcell ecosystem.
@rossbar rossbar force-pushed the ci/test-against-deepcell-dev branch from 17767d5 to ed19648 Compare January 6, 2023 01:17
@rossbar
Copy link
Contributor Author

rossbar commented Jan 6, 2023

Sorry for the swirling - I wasn't convinced this was installing the dev branches correctly. Merging now!

@rossbar rossbar merged commit 3fe695f into vanvalenlab:master Jan 6, 2023
@rossbar rossbar deleted the ci/test-against-deepcell-dev branch January 6, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants