Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix threadpool usage and update README #10

Merged
merged 2 commits into from
May 12, 2020
Merged

Fix threadpool usage and update README #10

merged 2 commits into from
May 12, 2020

Conversation

grahamburgsma
Copy link
Contributor

Realized a mistake in my previous PR, the thread pool must be started before using.

Also updated the README with the changes for 3.0.0.

@grahamburgsma
Copy link
Contributor Author

@mcdappdev could you please review?

jdmcd
jdmcd approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@jdmcd jdmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jdmcd jdmcd merged commit 48b4819 into vapor-community:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdmcd jdmcd jdmcd approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grahamburgsma @jdmcd