Add TLS/SSL support for plugin grpc server #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewHink
approved these changes
Aug 31, 2018
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
==========================================
+ Coverage 86.48% 86.65% +0.17%
==========================================
Files 31 31
Lines 2227 2293 +66
==========================================
+ Hits 1926 1987 +61
- Misses 266 269 +3
- Partials 35 37 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #300
Not 100% sure that this is complete, but from my limited testing, it seems to work. This seems to be on par with other examples I've found for how to implement this as well.