Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding unit tests, pt. 2 #383

Merged
merged 4 commits into from
Feb 26, 2019
Merged

adding unit tests, pt. 2 #383

merged 4 commits into from
Feb 26, 2019

Conversation

edaniszewski
Copy link
Contributor

This PR adds a bunch of unit tests, does some cleanup, and fixes some bugs found as a result of the tests. There is more work to be done, but opening this PR to try and keep the size manageable at least.

The primary work here is in the sub-packages where we will have pretty good coverage.

ok  	github.com/vapor-ware/synse-sdk/sdk	1.053s	coverage: 14.3% of statements
ok  	github.com/vapor-ware/synse-sdk/sdk/config	1.058s	coverage: 94.8% of statements
ok  	github.com/vapor-ware/synse-sdk/sdk/errors	1.031s	coverage: 100.0% of statements
ok  	github.com/vapor-ware/synse-sdk/sdk/health	1.040s	coverage: 77.0% of statements
ok  	github.com/vapor-ware/synse-sdk/sdk/output	1.037s	coverage: 100.0% of statements
ok  	github.com/vapor-ware/synse-sdk/sdk/policy	1.034s	coverage: 100.0% of statements
ok  	github.com/vapor-ware/synse-sdk/sdk/scripts	1.049s	coverage: 100.0% of statements
ok  	github.com/vapor-ware/synse-sdk/sdk/utils	1.036s	coverage: 100.0% of statements

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

❗ No coverage uploaded for pull request base (v3/staging@ef98501). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             v3/staging     #383   +/-   ##
=============================================
  Coverage              ?   41.33%           
=============================================
  Files                 ?       35           
  Lines                 ?     2269           
  Branches              ?        0           
=============================================
  Hits                  ?      938           
  Misses                ?     1312           
  Partials              ?       19
Impacted Files Coverage Δ
sdk/output/reading.go 100% <100%> (ø)
sdk/health/periodic.go 85.29% <100%> (ø)
sdk/config/plugin.go 100% <100%> (ø)
sdk/health/manager.go 72% <100%> (ø)
sdk/output/output.go 100% <100%> (ø)
sdk/tag.go 53.89% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef98501...7794dee. Read the comment docs.

@edaniszewski edaniszewski merged commit f3d3813 into v3/staging Feb 26, 2019
@edaniszewski edaniszewski deleted the v3/tests-2 branch February 26, 2019 22:46
edaniszewski added a commit that referenced this pull request Mar 27, 2020
edaniszewski added a commit that referenced this pull request Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant