This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
Functional verification for SNMPv3 with MD5/DES #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewHink
force-pushed
the
mhink-md5-des
branch
from
f7b7031 to
f76e604
Compare
MatthewHink
changed the title
MatthewHink
force-pushed
the
mhink-md5-des
branch
5 times, most recently
from
d6658cc to
79ec3e6
Compare
https://vaporio.atlassian.net/browse/VIO-1919 This already worked, here is functional verification. This PR also fixes the tests in CI which were silently not running and therefore false passing. That looks like it was broken months ago. See this run: https://build.vio.sh/blue/organizations/jenkins/vapor-ware%2Fsynse-snmp-plugin/detail/craig-VIO-1911-7/7/pipeline/113 Click on Integration Test Expand make integration-test Result: + make integration-test make: Nothing to be done for 'integration-test'. Meaning: Tests were not running in CI. This PR requires: https://github.com/vapor-ware/ci-shared/pull/195 vapor-ware/snmp-emulator#6
MatthewHink
force-pushed
the
mhink-md5-des
branch
from
79ec3e6 to
9658241
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This already worked, here is functional verification.
This PR also fixes the tests in CI which were silently not running
and therefore false passing. That looks like it was broken months ago.
See this run: https://build.vio.sh/blue/organizations/jenkins/vapor-ware%2Fsynse-snmp-plugin/detail/craig-VIO-1911-7/7/pipeline/113
Click on Integration Test
Expand make integration-test
Result:
+ make integration-test
make: Nothing to be done for 'integration-test'.
Meaning: Tests were not running in CI.
This PR requires:
MERGED: https://github.com/vapor-ware/ci-shared/pull/195
vapor-ware/snmp-emulator#6
DONE: bump library identifier to the new version once the ci-shared PR lands.
https://github.com/vapor-ware/ci-shared/pull/195