Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in connection request error message #108

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Fix typo in connection request error message #108

merged 1 commit into from
Jul 21, 2024

Conversation

rausnitz
Copy link
Contributor

@rausnitz rausnitz commented Jul 18, 2024

These changes are now available in 1.19.1

There's a parenthesis missing in the connection request error message.

This fixes #107.

@rausnitz rausnitz requested review from 0xTim and gwynne as code owners July 18, 2024 21:40
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim 0xTim added the semver-patch Internal changes only label Jul 21, 2024
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (bfcc9cb) to head (8da138b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   96.74%   96.56%   -0.19%     
==========================================
  Files          19       19              
  Lines         860      814      -46     
==========================================
- Hits          832      786      -46     
  Misses         28       28              
Files Coverage Δ
...ncKit/ConnectionPool/EventLoopConnectionPool.swift 94.30% <100.00%> (-0.55%) ⬇️

... and 7 files with indirect coverage changes

@0xTim 0xTim merged commit 15b3fb7 into vapor:main Jul 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log message in _requestConnection0 has typo
2 participants