Leverage the new support for nested path expressions in SQLKit #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reimplement SQLJSONColumnPath in favor of SQLNestedSubpathExpression, default SQLConverterDelegates to using the latter.
This was referenced Jul 11, 2023
|
These changes are now available in 1.43.0 |
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Aug 25, 2023
…543) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [vapor/fluent-sqlite-driver](https://github.com/vapor/fluent-sqlite-driver) | minor | `4.3.0` -> `4.5.0` | --- ### Release Notes <details> <summary>vapor/fluent-sqlite-driver (vapor/fluent-sqlite-driver)</summary> ### [`v4.5.0`](https://github.com/vapor/fluent-sqlite-driver/releases/tag/4.5.0): - Update for the nested subpath changes in FluentKit [Compare Source](https://github.com/vapor/fluent-sqlite-driver/compare/4.4.0...4.5.0) ###### *This patch was authored and released by [@​gwynne](https://github.com/gwynne).* [vapor/fluent-kit#572](https://github.com/vapor/fluent-kit/issues/572) takes advantage of the new support added to SQLKit in [vapor/sql-kit#169](https://github.com/vapor/sql-kit/issues/169), so remove the obsolete legacy support here. Also does some minor tidying. (Note: Since we now depend on a version of FluentKit that is multiple minor versions newer than before, this must also be semver-minor.) [https://github.com/vapor/fluent-sqlite-driver/pull/87](https://github.com/vapor/fluent-sqlite-driver/pull/87) ### [`v4.4.0`](https://github.com/vapor/fluent-sqlite-driver/releases/tag/4.4.0): Update min Swift version to 5.6 and make platform versions consistent [Compare Source](https://github.com/vapor/fluent-sqlite-driver/compare/4.3.1...4.4.0) ###### *This patch was authored and released by [@​gwynne](https://github.com/gwynne).* ### [`v4.3.1`](https://github.com/vapor/fluent-sqlite-driver/releases/tag/4.3.1): Add experimental support for watchOS [Compare Source](https://github.com/vapor/fluent-sqlite-driver/compare/4.3.0...4.3.1) ###### *This patch was authored by [@​hyouuu](https://github.com/hyouuu) and released by [@​0xTim](https://github.com/0xTim).* Adds watchOS adds a target platform to enable it to be built for that platform. **Note:** watchOS support is very much experimental and not currently a supported platform, though there is no reason why it shouldn't work </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ny4zIiwidXBkYXRlZEluVmVyIjoiMzYuNTcuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fluent now takes generic advantage of the new support added by vapor/sql-kit#169 when generating nested subpath expressions.
(Unfortunately, Fluent has never actually invoked this code path to begin with, except via an explicit call to
.sql(json:_:), so it doesn't change much at the moment. However, this would always have been a prerequisite to make the real support for it in Fluent's API actually work, so it's a step in the right direction.)SQLJSONColumnPathis now deprecated in favor of using SQLKit's newSQLNestedSubpathExpression.