Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Sendable Work #128

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Initial Sendable Work #128

merged 4 commits into from
Nov 6, 2023

Conversation

0xTim
Copy link
Member

@0xTim 0xTim commented Nov 6, 2023

Conform Parameters, PathComponent and ConfigurationOption to Sendable.

Also sets up a 5.9 manifest to enable Sendable Checking. Making TrieRouter Sendable will be a future PR

@0xTim 0xTim requested a review from gwynne as a code owner November 6, 2023 17:02
@0xTim 0xTim added the semver-patch Internal changes only label Nov 6, 2023
MahdiBM
MahdiBM approved these changes Nov 6, 2023
View reviewed changes
Copy link

@MahdiBM MahdiBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was an easy one

@0xTim 0xTim merged commit 17a7a3f into main Nov 6, 2023
13 checks passed
@0xTim 0xTim deleted the sendable-changes branch November 6, 2023 18:13
@penny-for-vapor
Copy link

These changes are now available in 4.8.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MahdiBM MahdiBM MahdiBM approved these changes

@gwynne gwynne Awaiting requested review from gwynne gwynne is a code owner

Assignees
No one assigned
Labels
semver-patch Internal changes only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xTim @MahdiBM