-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: cache mappers, avoid allocations, codons are arrays #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of reference lookup tables
tedil
changed the title
enhancement: Performance improvements: cache mappers, avoid allocations, codons are arrays
feat: Performance improvements: cache mappers, avoid allocations, codons are arrays
Jun 10, 2024
tedil
changed the title
feat: Performance improvements: cache mappers, avoid allocations, codons are arrays
perf: Performance improvements: cache mappers, avoid allocations, codons are arrays
Jun 10, 2024
tedil
changed the title
perf: Performance improvements: cache mappers, avoid allocations, codons are arrays
perf: cache mappers, avoid allocations, codons are arrays
Jun 10, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
- Coverage 87.42% 86.34% -1.09%
==========================================
Files 18 18
Lines 7705 7145 -560
==========================================
- Hits 6736 6169 -567
- Misses 969 976 +7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't realize we already depend on
quick_cache
, so perhaps replace the newcached
dep with that.The key for caching currently relies on the provider supplying consistent
data_version
andschema_version
information.Todo: Should depend on next seqrepo release.