waiter: report WAITER_REMCLOSE correctly #4138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigoroll
added a commit
that referenced
this pull request
Jul 29, 2024
"999 pools ought to be enough for everyone" yet the actual maximum is UINT_MAX. Noticed while staring at #4138
nigoroll
approved these changes
Jul 29, 2024
|
bugwash: Ok to merge. But, we should keep an eye on it w.r.t regression. |
Introduce counters that can be used by the Waiter. Signed-off-by: Asad Sajjad Ahmed <asadsa@varnish-software.com>
Make the Waiter more transparent from the outside. Signed-off-by: Asad Sajjad Ahmed <asadsa@varnish-software.com>
Let a client or server perform a graceful shutdown. By default, we close both directions. Options can be given to only close read or write direction. Signed-off-by: Asad Sajjad Ahmed <asadsa@varnish-software.com>
There seems to be a discrepancy between the epoll and kqueue implementation. One implementation is not reporting WAITER_REMCLOSE, while the other implementation is reporting WAITER_REMCLOSE too soon. epoll: We sometimes incorrectly report WAITER_ACTION when it is supposed to be WAITER_REMCLOSE. We can check EPOLLRDHUP before reading 1 byte with MSG_PEEK to detect WAITER_REMCLOSE. This saves us from a pontential session detour from the Waiter to a worker thread. kqueue: We incorrectly report WAITER_REMCLOSE when there could be more data to be read from the socket. Change this so that we perform read of 1 byte with MSG_PEEK to detect closure when EV_EOF is set. DESCRIPTION:EVFILT_READ:Sockets: "It is possible for EOF to be returned (indicating the connection is gone) while there is still data pending in the socket buffer." - kqueue (2) Signed-off-by: Asad Sajjad Ahmed <asadsa@varnish-software.com>
|
Rebased to solve a filename conflict for one of the test case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a discrepancy between the epoll and kqueue
implementation. One implementation is not reporting WAITER_REMCLOSE,
while the other implementation is reporting WAITER_REMCLOSE too soon.
epoll:
We sometimes incorrectly report WAITER_ACTION when it is supposed to be
WAITER_REMCLOSE. We can check EPOLLRDHUP before reading 1 byte with MSG_PEEK to
detect WAITER_REMCLOSE. This saves us from a pontential session detour from the
Waiter to a worker thread.
kqueue:
We incorrectly report WAITER_REMCLOSE when there could be more data to be
read from the socket. Change this so that we perform read of 1 byte with
MSG_PEEK to detect closure when EV_EOF is set.
DESCRIPTION:EVFILT_READ:Sockets: