Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cifuzz: Update upload action to v4 #4175

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

cartoush
Copy link
Contributor

V1 and V2 of the upload-artifact action are now deprecated, this PR sets it to V4

Copy link
Member

@dridi dridi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error logs I'm seeing look completely harmless:

2024-09-12 12:16:33,573 - root - DEBUG - Stderr of command "docker rmi -f gcr.io/oss-fuzz/varnish gcr.io/oss-fuzz-base/base-builder gcr.io/oss-fuzz-base/base-builder-go gcr.io/oss-fuzz-base/base-builder-javascript gcr.io/oss-fuzz-base/base-builder-jvm gcr.io/oss-fuzz-base/base-builder-python gcr.io/oss-fuzz-base/base-builder-rust gcr.io/oss-fuzz-base/base-builder-ruby gcr.io/oss-fuzz-base/base-builder-swift" is: Error: No such image: gcr.io/oss-fuzz-base/base-builder
Error: No such image: gcr.io/oss-fuzz-base/base-builder-go
Error: No such image: gcr.io/oss-fuzz-base/base-builder-javascript
Error: No such image: gcr.io/oss-fuzz-base/base-builder-jvm
Error: No such image: gcr.io/oss-fuzz-base/base-builder-python
Error: No such image: gcr.io/oss-fuzz-base/base-builder-rust
Error: No such image: gcr.io/oss-fuzz-base/base-builder-ruby
Error: No such image: gcr.io/oss-fuzz-base/base-builder-swift
.

@cartoush cartoush marked this pull request as ready for review September 12, 2024 13:56
@dridi
Copy link
Member

dridi commented Sep 13, 2024

I'm going to merge this now, and the only failure left in circleci is a use-after-free being investigated by @walid-git.

@dridi dridi merged commit 5caded9 into varnishcache:master Sep 13, 2024
10 of 11 checks passed
@dridi dridi deleted the update-gh-action branch September 13, 2024 07:51
@dridi
Copy link
Member

dridi commented Sep 13, 2024

For reference, with 168ebab our CI here should be back to passing all jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants