Prepare for 7.6.0 #4178
Merged
Prepare for 7.6.0 #4178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonvik
force-pushed
the
7.6
branch
3 times, most recently
from
54fcaa2
to
a916d97
Compare
dridi
requested changes
Sep 13, 2024
Comment on lines
30
to
33
| The port of a *listen_endpoint* given with the ``-a`` argument to ``varnishd`` | ||
| can now also be a numerical port range like ``80-89``, besides the existing | ||
| options of port number (e.g. ``80``) and service name (e.g. ``http``). With a | ||
| port range, Varnish will accept connections on all ports within the range. |
There was a problem hiding this comment.
Is the range inclusive? I think it should tell here even if it is not the reference manual.
There was a problem hiding this comment.
for (i = lo; i <= hi && !error; i++) {
Its inclusive and thats the only thing that makes sense?
There was a problem hiding this comment.
Not sure it's the only one, I had to pause and wonder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers must check the following items:
include/vrt.his populatedVRT_MAJOR_VERSIONwas updated if applicableVRT_MINOR_VERSIONwas updated if applicabledevicedetect.vclwas updated (major release only)./autogen.des && make distchecksucceedsconfigure.acis correctconfigure.accovers the current yearlib/libvarnish/version.ccovers the current year