Issue closed. FIXME removed. (cs3org#3311)

* Issue closed. FIXME removed. * Modify changelog. * Fix changelog. Co-authored-by: Antoon P <antoon@redblom.com>
vascoguita · Oct 20, 2022 · ee618b3 · ee618b3
1 parent 25840a0
commit ee618b3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/changelog/unreleased/fix-closed-FIXME.md b/changelog/unreleased/fix-closed-FIXME.md
@@ -0,0 +1,5 @@
+Bugfix: Remove FIXME
+
+Issue https://github.com/cs3org/reva/issues/2402 is closed.
+
+https://github.com/cs3org/reva/pull/3311
diff --git a/internal/grpc/services/ocmshareprovider/ocmshareprovider.go b/internal/grpc/services/ocmshareprovider/ocmshareprovider.go
@@ -158,7 +158,6 @@ func (s *service) CreateOCMShare(ctx context.Context, req *ocm.CreateOCMShareReq
 
 	// discover share type
 	sharetype := ocm.Share_SHARE_TYPE_REGULAR
-	// FIXME: https://github.com/cs3org/reva/issues/2402
 	protocol, ok := req.Opaque.Map["protocol"]
 	if ok {
 		switch protocol.Decoder {
@@ -172,7 +171,6 @@ func (s *service) CreateOCMShare(ctx context.Context, req *ocm.CreateOCMShareReq
 				Status: status.NewInternal(ctx, err, "error creating share"),
 			}, nil
 		}
-		// token = protocol FIXME!
 	}
 
 	var sharedSecret string