Add autosave functionality to BasicLogger #13679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uckelman
reviewed
Nov 7, 2024
uckelman
reviewed
Nov 7, 2024
| } | ||
|
|
||
| private void startAutosave() { | ||
| scheduler.scheduleAtFixedRate(this::autosave, 5, 5, TimeUnit.SECONDS); |
There was a problem hiding this comment.
Five seconds is probably too short.
There's nothing to debounce the autosave if autosaving takes longer than the autosave interval.
There was a problem hiding this comment.
I changed that to start after a minute and save every 5 minutes.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces an autosave feature to the
BasicLoggerclass in the Vassal application. The most important changes include the addition of a scheduled executor service to handle periodic autosaving, the implementation of the autosave logic, and modifications to thewritemethod to support writing to a specified file. We simply append the word autosave_ to the current file we are logging to and then save to that file every 5 minutes.Autosave Feature Implementation:
ScheduledExecutorServicetoBasicLoggerfor scheduling periodic tasks. [1] [2]startAutosavemethod to schedule theautosavemethod at fixed intervals.autosavemethod to handle the logic of saving the log file periodically.Modifications to Writing Logic:
writemethod to support writing to a specified file, used by the autosave feature.Localization:
VASSAL.properties.