Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in Makefile when pulling from branch with "/" in name #13687

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bug in Makefile when pulling from branch with "/" in name #13687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ MAVEN_VERSION:=$(VNUM)-SNAPSHOT

JARNAME:=vassal-app-$(MAVEN_VERSION)

GITBRANCH:=$(shell git rev-parse --abbrev-ref HEAD)
#Slashes are substituted so as not to create subdirectories
GITBRANCH := $(subst /,_,$(shell git rev-parse --abbrev-ref HEAD))
GITCOMMIT:=$(shell git rev-parse --short HEAD)

ifeq ($(shell git describe --tags), $(MAVEN_VERSION))
Expand Down