-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2 #152
Version 2 #152
Conversation
a51e4f4
to
beb8aa9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zendranm , some suggestions from me below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Let's schedule a meeting after you'll address all of the comments and TODO
s, as I have a couple of ideas when it comes to the documentation.
Also, could you already look into CI?
Puppeteer has to be installed as Meteor |
- name: Install Meteor | ||
env: | ||
METEOR_VERSION: ${{ matrix.meteor-version }} | ||
run: curl https://install.meteor.com/?release=$METEOR_VERSION | /bin/sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would probably be worth caching both meteor and npm install dependencies - doesn't have to be within this PR though.
|
||
```bash | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have tests for all of the examples here? We should.
As discussed today: let's focus on checking the normalization (#152 (comment)) and we could release an alpha. The rest (caching on CI, more tests) can be done later. |
@radekmie The normalization was tested and it works. For now only one param form the |
Info: Marked as Draft to prevent from merging
This PR is focused on the first three parts of the issue #144 . Documentation is still in work in progress. It will be completed after all changes from v2 were implemented.
Main changes:
xx
andxx-XX
, wherex
is lowercase letter andX
is uppercase letter.createTranslator
,createReactiveTranslator
,purify
andparseNumber
functions.format
function.getTranslation
function.