Removing usage of Fibers #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radekmie
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
So that'd mean the sameLocaleOnServerConnection option is no longer working? If so, we should make it explicit.
Alternatively, we could still override the get but instead of checking the Fiber, just call the original get and fall back to _getConnectionLocale. It needs testing, though.
|
@radekmie You're right, removing the entire override breaks the |
Closed
radekmie
approved these changes
Mar 16, 2023
piotrpospiech
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the only usage of Fibers by removing the custom
getfunction used to override nativeMeteor.EnvironmentVariable'sgetmethod. The behavior of therunWithLocaleandgetLocalefunctions after removing the override is the same.