Skip to content

Commit

Permalink
node_config: Enable large alloc warnings above 128KiB by default
Browse files Browse the repository at this point in the history
We already have the reactor stall warnings on in "prod" and arguably the
large allocs are more important as they actually might result in a
crash.

Further the large alloc threshold automatically increases after each
warning so it's unlikely for this to be very spamy.
  • Loading branch information
StephanDollberg committed Mar 1, 2024
1 parent 9b7ff60 commit 2be51c0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/v/config/node_config.cc
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ node_config::node_config() noexcept
"memory_allocation_warning_threshold",
"Enables log messages for allocations greater than the given size.",
{.visibility = visibility::tunable},
std::nullopt)
128_KiB + 1) // 128 KiB is the largest allowed allocation size
, storage_failure_injection_enabled(
*this,
"storage_failure_injection_enabled",
Expand Down

0 comments on commit 2be51c0

Please sign in to comment.