Skip to content

Commit

Permalink
sagemathgh-38915: Remove register macro in Ginac
Browse files Browse the repository at this point in the history
    
Fixes
```
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14
.41.34120\include\xkeycheck.h(341): warning C4005: 'register': macro
redefinition
../src/sage/symbolic/ginac/constant.cpp(23): note: see previous
definition of 'register'
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14
.41.34120\include\xkeycheck.h(343): fatal error C1189: #error:  The C++
Standard Library forbids macroizing the keyword "register". Enable
warning C4005 to find the forbidden define.
```

Not sure why `register` was declared there in the first place.

<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38915
Reported by: Tobias Diez
Reviewer(s): Travis Scrimshaw
  • Loading branch information
Release Manager committed Nov 7, 2024
2 parents c501a0c + ee7d196 commit fe65b4d
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 6 deletions.
1 change: 0 additions & 1 deletion src/sage/symbolic/ginac/constant.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/

#define register
#include <Python.h>
#include "py_funcs.h"
#include "constant.h"
Expand Down
1 change: 0 additions & 1 deletion src/sage/symbolic/ginac/ex.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/

#define register
#include <Python.h>
#include "ex.h"
#include "ex_utils.h"
Expand Down
1 change: 0 additions & 1 deletion src/sage/symbolic/ginac/fderivative.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/

#define register
#include <Python.h>
#include "py_funcs.h"
#include "fderivative.h"
Expand Down
1 change: 0 additions & 1 deletion src/sage/symbolic/ginac/function.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/

#define register
#define PY_SSIZE_T_CLEAN
#include <Python.h>
#include "py_funcs.h"
Expand Down
1 change: 0 additions & 1 deletion src/sage/symbolic/ginac/inifcns_hyperg.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/

#define register
#include <Python.h>
#include "py_funcs.h"
#include "inifcns.h"
Expand Down
1 change: 0 additions & 1 deletion src/sage/symbolic/ginac/numeric.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/

#define register
#define PY_SSIZE_T_CLEAN
#include <Python.h>
#include "flint/fmpz.h"
Expand Down

0 comments on commit fe65b4d

Please sign in to comment.