More foreach removal

Added instruction clearing on pooled entities. Added memory output in release mode.
vchelaru · Dec 27, 2023 · f3027db · f3027db
1 parent 9cb6826
commit f3027db
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/Engines/FlatRedBallXNA/FlatRedBall/Debugging/Debugger.cs b/Engines/FlatRedBallXNA/FlatRedBall/Debugging/Debugger.cs
@@ -56,10 +56,11 @@ public enum Corner
 
         static List<string> mCommandLineOutput = new List<string>();
 
-#if DEBUG
+        // Why is this expensive to have in debug? If the user doesn't ask for memory, this doesn't get used.
+//#if DEBUG
         static RollingAverage mAllocationAverage = new RollingAverage(4);
         static long mLastMemoryUse = -1;
-#endif
+//#endif
 
         public static StringBuilder LogStringBuilder = new StringBuilder();
 
@@ -212,7 +213,6 @@ public static string ForceGetMemoryInformation()
                 currentUsage = GC.GetTotalMemory(false);
                 memoryInformation = "Total Memory: " + currentUsage.ToString("N0");
 
-#if DEBUG
             if (mLastMemoryUse >= 0)
             {
                 long difference = currentUsage - mLastMemoryUse;
@@ -224,12 +224,9 @@ public static string ForceGetMemoryInformation()
             }
             memoryInformation += "\nAverage Growth per second: " +
                 mAllocationAverage.Average.ToString("N0");
-#endif
 
             LastCalculationTime = TimeManager.CurrentTime;
-#if DEBUG
             mLastMemoryUse = currentUsage;
-#endif
 
 
             return memoryInformation;

diff --git a/FRBDK/Glue/Glue/Plugins/EmbeddedPlugins/FactoryPlugin/FactoryElementCodeGenerator.cs b/FRBDK/Glue/Glue/Plugins/EmbeddedPlugins/FactoryPlugin/FactoryElementCodeGenerator.cs
@@ -188,6 +188,10 @@ public override ICodeBlock GenerateDestroy(ICodeBlock codeBlock, IElement elemen
 
                 }
             }
+            else if(element is EntitySave entitySave && entitySave.PooledByFactory && entitySave.CreatedByOtherEntities)
+            {
+                codeBlock.Line($"this.Instructions.Clear();");
+            }
 
             return codeBlock;
         }

diff --git a/FRBDK/Glue/GumPlugin/GumPlugin/Embedded/GraphicalUiElement.IWindow.cs b/FRBDK/Glue/GumPlugin/GumPlugin/Embedded/GraphicalUiElement.IWindow.cs
@@ -1157,9 +1157,10 @@ private void TryPushBindingContextChangeToChildren(string vmPropertyName)
         {
             if (this.Children != null)
             {
-                foreach(var child in Children)
+                for (int i = 0; i < Children.Count; i++)
                 {
-                    if(child is GraphicalUiElement gue)
+                    IRenderableIpso child = Children[i];
+                    if (child is GraphicalUiElement gue)
                     {
                         if (gue.BindingContextBinding == vmPropertyName && gue.BindingContextBindingPropertyOwner == EffectiveBindingContext)
                         {
@@ -1171,8 +1172,9 @@ private void TryPushBindingContextChangeToChildren(string vmPropertyName)
             }
             else
             {
-                foreach(var gue in ContainedElements)
+                for (int i = 0; i < mWhatThisContains.Count; i++)
                 {
+                    GraphicalUiElement gue = mWhatThisContains[i];
                     if (gue.BindingContextBinding == vmPropertyName && gue.BindingContextBindingPropertyOwner == EffectiveBindingContext)
                     {
                         gue.UpdateToVmProperty(vmPropertyName);