Skip to content

Commit

Permalink
Use vendor-ed version of plumbing instead of go get 🦸
Browse files Browse the repository at this point in the history
Using `go get -d` updates continuously the plumbing dependency,
without really updating the vendor folder, which means it becomes
inconsistency.

This is a follow-up of tektoncd#1763.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
  • Loading branch information
vdemeester committed Jan 6, 2020
1 parent e2a0084 commit b143d24
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions test/e2e-common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@

# Helper functions for E2E tests.

go get -d github.com/tektoncd/plumbing
source $(go list -m -f '{{.Dir}}' github.com/tektoncd/plumbing)/scripts/e2e-tests.sh
source $(dirname $0)/../vendor/github.com/tektoncd/plumbing/scripts/e2e-tests.sh

function teardown() {
subheader "Tearing down Tekton Pipelines"
Expand Down
3 changes: 1 addition & 2 deletions test/presubmit-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@
export DISABLE_MD_LINTING=1
export DISABLE_MD_LINK_CHECK=1

go get -d github.com/tektoncd/plumbing
source $(go list -m -f '{{.Dir}}' github.com/tektoncd/plumbing)/scripts/presubmit-tests.sh
source $(dirname $0)/../vendor/github.com/tektoncd/plumbing/scripts/presubmit-tests.sh

function post_build_tests() {
header "running golangci-lint"
Expand Down

0 comments on commit b143d24

Please sign in to comment.