Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicator of seek bar on audio player not reset to zero #24898

Closed
luixxiul opened this issue Mar 22, 2023 · 3 comments
Closed

Indicator of seek bar on audio player not reset to zero #24898

luixxiul opened this issue Mar 22, 2023 · 3 comments
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect

Comments

@luixxiul
Copy link

luixxiul commented Mar 22, 2023

Steps to reproduce

  1. Open a room
  2. Upload an audio file
  3. Play it and wait until the counter resets zero

Outcome

What did you expect?

The indicator of the seek bar should be reset to zero.

What happened instead?

It is reset to nearly zero, but not exactly. The position of the indicator slightly changes every time it resets, as the values --fillTo below show.

Screenshot from 2023-03-23 04-22-51
Screenshot from 2023-03-23 04-23-02

Both cases --fillTo and value are expected to be zero, unless intended.

The counter is reset to zero.

This issue essentially causes flaky Percy test reported here: #24897

Operating system

Debian

Browser information

Firefox

URL for webapp

No response

Application version

develop branch

Homeserver

No response

Will you send logs?

No

@artcodespace artcodespace added S-Tolerable Low/no impact on users A-Developer-Experience O-Occasional Affects or can be seen by some users regularly or most users rarely labels Mar 23, 2023
@artcodespace
Copy link

@luixxiul Good spot! Easily reproducible on the nightly build, have tagged as tolerable (from the user's perspective), but fixing anything that helps decrease flaky tests and improve developer experience is very helpful for us.

@richvdh
Copy link
Member

richvdh commented Mar 23, 2023

When fixing this: note that the seek bar was disabled in Percy in order to stop it flaking out due to this bug. matrix-org/matrix-react-sdk@5a1a91f should be reverted once the bug is fixed.

@t3chguy
Copy link
Member

t3chguy commented Apr 19, 2024

Percy tests are gone

@t3chguy t3chguy closed this as completed Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

No branches or pull requests

5 participants