-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Docker Support #17
Conversation
So we can say we replace the riot-web package
So you can run yarn install in the docker container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm. Please change the script name ._.
package.json
Outdated
@@ -18,6 +18,9 @@ | |||
"start": "electron .", | |||
"lint": "eslint src/", | |||
"build": "yarn run setversion && electron-builder", | |||
"indocker": "scripts/indocker.sh", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we call it something else or add punctuation? I'm probably the only one with the problem, but every time I've read this it's either "indicator" or something NSFW. "in-docker" would be fine imo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I;d be up for changing it - just used the value we'd been using previously
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I'd be up for changing it - just used the value we'd been using previously
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I'd be up for changing it - just used the value we'd been using previously
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I'd be up for changing it - just used the value we'd been using previously
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I'd be up for changing it - just used the value we'd been using previously
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I'd be up for changing it - just used the value we'd been using previously
So you can run yarn install in the docker container
Based on #14