Skip to content

Commit

Permalink
fix(vector): Allow empty workloadResourceAnnotations (#435)
Browse files Browse the repository at this point in the history
Fix empty annotations when no workloadResourceAnnotations is defined

This prevents from settings empty annotations like `annotations: {}` which causes argocd to always see DaemonSet as out of sync, because a DaemonSet will get `deprecated.daemonset.template.generation` annotation anyways
  • Loading branch information
nebula-it authored Dec 10, 2024
1 parent 4efd0a7 commit 516885f
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion charts/vector/templates/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@ metadata:
name: {{ include "vector.fullname" . }}
labels:
{{- include "vector.labels" . | nindent 4 }}
{{- with .Values.workloadResourceAnnotations }}
annotations:
{{- toYaml .Values.workloadResourceAnnotations | nindent 4 }}
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
selector:
matchLabels:
Expand Down

0 comments on commit 516885f

Please sign in to comment.