enhancement(vector): Allow external autoscaler #386
Conversation
srstrickland
force-pushed
the
allow-external-autoscaler
branch
3 times, most recently
from
6e0828c to
90855c1
Compare
There was a problem hiding this comment.
Thanks for this contribution @srstrickland ! I think you just need to bump the chart version to satisfy the linter in CI.
jszwedko
changed the title
|
Ah, great... will do. Should I put in a note in the (also thx for fixing PR title 😄) |
Ah, I missed the version was updated in another PR. This is a feature addition rather than a bug fix, though, so we should update to 0.33.0 to follow semver. The changelog is generated during release, from commit titles, so you don't have to update that. |
When using any autoscaler, replicas should not be set on any Deployment or StatefulSet. This helm chart has hooks for defining an HPA, but there are times when users may want to create their own, or use something external like [KEDA](https://keda.sh). In our case, we want to use KEDA for scaling based on kafka lag and other triggers. This largely works as expected, but I need to prevent the `replicas` field from being populated, or else things appear out-of-sync when the external autoscaler is doing its thing (we use ArgoCD and it will show the project as out-of-sync because of replicas). The feature here is just to offer an additional field under `autoscaling` options: `external: true/false`.
srstrickland
force-pushed
the
allow-external-autoscaler
branch
from
90855c1 to
174c756
Compare
|
Any thoughts on when 0.33.0 will be published? It's not blocking me; I've published this update to our own internal repo, just would prefer to use the official one whenever it's available. |
Should be this week! |
When using any autoscaler, replicas should not be set on any Deployment or StatefulSet. This helm chart has hooks for defining an HPA, but there are times when users may want to create their own, or use something external like KEDA. In our case, we want to use KEDA for scaling based on kafka lag and other triggers. This largely works as expected, but I need to prevent the
replicasfield from being populated, or else things appear out-of-sync when the external autoscaler is doing its thing (we use ArgoCD and it will show the project as out-of-sync because of replicas).The feature here is just to offer an additional field under
autoscalingoptions:external: true/false.