Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update configmap.yaml #427

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Update configmap.yaml #427

merged 1 commit into from
Nov 26, 2024

Conversation

k-harutyunyan
Copy link
Contributor

This condition checks for the customConfig field for the vector config not the haproxy, hence when you have a customConfig set for vector and enable haproxy you get empty haproxy config.

pront
pront approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@pront pront left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @k-harutyunyan

@pront pront mentioned this pull request Nov 26, 2024
Merged
@pront
Copy link
Member

pront commented Nov 26, 2024

Can you rebase on the latest develop branch? Thanks!

@pront pront enabled auto-merge (squash) November 26, 2024 20:35
@pront pront merged commit e72ab22 into vectordotdev:develop Nov 26, 2024
11 checks passed
@k-harutyunyan k-harutyunyan deleted the patch-1 branch November 26, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pront pront pront approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-harutyunyan @pront