Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appsignal sink should apply user-defined TLS settings #17112

Closed
neuronull opened this issue Apr 11, 2023 · 1 comment · Fixed by #17122
Closed

appsignal sink should apply user-defined TLS settings #17112

neuronull opened this issue Apr 11, 2023 · 1 comment · Fixed by #17122
Labels
sink: appsignal Anything `appsignal` sink related

Comments

@neuronull
Copy link
Contributor

As observed in #17110 , the sink is currently not allowing user defined TLS settings (https://cs.github.com/vectordotdev/vector/blob/a791595b0cfcae36d0c46708a91d5e2813ed38eb/src/sinks/appsignal/mod.rs#L117).

The can be adressed by adding the TlsSettings to the config struct for the sink and applying them instead of &None.
@neuronull neuronull mentioned this issue Apr 11, 2023
Closed
tombruijn added a commit to appsignal/vector that referenced this issue Apr 12, 2023
@tombruijn
Add TLS config option to AppSignal sink
127c655 
This allows users to configure TLS settings for the AppSignal sink.

Closes vectordotdev#17112
tombruijn added a commit to appsignal/vector that referenced this issue Apr 12, 2023
@tombruijn
fix(appsignal sink): Add TLS config option
8f91975 
This allows users to configure TLS settings for the AppSignal sink.

Closes vectordotdev#17112
@tombruijn tombruijn mentioned this issue Apr 12, 2023
Merged
@tombruijn
Copy link
Contributor

I've created a PR with a fix: #17122

@neuronull neuronull added the sink: appsignal Anything `appsignal` sink related label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sink: appsignal Anything `appsignal` sink related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(appsignal sink): Add TLS config option appsignal/vector
2 participants
@tombruijn @neuronull