Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the emitted events to accept the new tags - taking the telemetry configuration options into account. #17581

Closed
Tracked by #17576
StephenWakely opened this issue Jun 2, 2023 · 0 comments · Fixed by #17549
Closed
Tracked by #17576

Update the emitted events to accept the new tags - taking the telemetry configuration options into account. #17581

StephenWakely opened this issue Jun 2, 2023 · 0 comments · Fixed by #17549

Comments

@StephenWakely
Copy link
Contributor

No description provided.

This was referenced Jun 2, 2023
Open
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 26, 2023
@StephenWakely
chore(observability): emit component_sent events by source and `s…
dcf7f9a 
…ervice` (#17549)

Closes #17580 
Closes #17581 

This is still in draft until I can get the following done.

- [ ] ~~There are way more clones that I am happy with here, especially
since this is in a hot path. These need reducing.~~

The remaining clones that I would like to remove are in the `get_tags`
functions. This didn't seem trivial, and given the fairly positive
regression numbers, I think it should be ok to defer for now.

- [x] Function documentation.
- [ ] Currently source schemas aren't being attached to the event at
runtime, so the service meaning can't be retrieved. That won't work
until this has been done. This will be a separate PR - #17692
- [x] I've only tested this with the kafka sink so far. I think it
should work with all Stream sinks without needing any further
modification - but further testing is needed.
- [x] Tests. A bunch of tests need writing. 
- [x] The Vector source tests are failing I think because we now have
`EventsSent` and `TaggedEventsSent` which both emit
`component_sent_event` events and the test framework doesn't like this.
This needs fixed.
- [ ] We will need to review every sink to ensure they work with this.
All the stream based sinks should, but the others are highly likely to
need some work.

---------

Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
@StephenWakely StephenWakely mentioned this issue Jun 27, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 28, 2023
@StephenWakely
fix(observability): issues with event_cache PR (#17768)
fdf02d9 
Ref #17580
Ref #17581

Re this PR #17549

This fixes a couple of issues with the mentioned PR.

- When telemetry was turned off it was still emitting the empty tags.
- The service tag was being emitted by converting the value using
`to_string`. This meant the value was delimited by `"`.
- A `telemetry` section is added to the global configuration docs.

---------

Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(observability): emit component_sent events by source and service vectordotdev/vector
1 participant
@StephenWakely