deb packaging: Two trailing \n in DEBIAN/conffiles prevent Uyuni/SUSE Manager from importing Vector deb repo

[senecops]

A note for the community

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

We noticed that deb packages generated by cloudsmith cannot be imported into Uyuni/SUSE Manager due to an empty newline in conffiles. Steps to check:

wget https://packages.timber.io/vector/0.42.0/vector_0.42.0-1_amd64.deb
dpkg-deb -e vector_0.42.0-1_amd64.deb
hd DEBIAN/conffiles

I also reproduced this with https://packages.timber.io/vector/nightly/latest/vector_nightly-1_amd64.deb as of 2023-08-31.

Outputs:

--2024-11-28 13:56:46--  https://packages.timber.io/vector/0.42.0/vector_0.42.0-1_amd64.deb
Resolving packages.timber.io (packages.timber.io)... 172.67.151.135, 104.21.90.25, 2606:4700:3031::6815:5a19, ...
Connecting to packages.timber.io (packages.timber.io)|172.67.151.135|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 30553270 (29M) [application/x-debian-package]
Saving to: ‘vector_0.42.0-1_amd64.deb’

vector_0.42.0-1_amd64.deb                       100%[=====================================================================================================>]  29.14M  8.63MB/s    in 3.8s    

2024-11-28 13:56:50 (7.59 MB/s) - ‘vector_0.42.0-1_amd64.deb’ saved [30553270/30553270]

00000000  2f 65 74 63 2f 76 65 63  74 6f 72 2f 76 65 63 74  |/etc/vector/vect|
00000010  6f 72 2e 79 61 6d 6c 0a  2f 65 74 63 2f 64 65 66  |or.yaml./etc/def|
00000020  61 75 6c 74 2f 76 65 63  74 6f 72 0a 0a           |ault/vector..|
0000002d

Note the two 0a. One newline is completely fine and expected. Two are not. The source definition does nothing wrong I would say, ref:

vector/Cargo.toml

Line 51 in 4cc9cdf

conf-files = ["/etc/vector/vector.toml", "/etc/default/vector"]

Configuration

No response

Version

vector 0.31.0 (x86_64-unknown-linux-gnu 0f13b22 2023-07-06 13:52:34.591204470)

Debug Output

No response

Example Data

No response

Additional Context

I reported this on 2023-08-09 to support@cloudsmith.io. They say the problem is caused by how Vector creates the package. I was able to confirm that by searching for another project and checking if their conffile also has double newline. https://cloudsmith.io/~isc/repos/stork/packages/detail/deb/isc-stork-server/1.12.0.230802125039/a=amd64;d=any-distro%252Fany-version;t=binary/ has a single new line.

References

• Enhance rhnpush to handle Debian packages. Was: 3 Problems with creating custom channels for Ubuntu. uyuni-project/uyuni#5212
• https://www.picotech.com/support/topic40901.html
• https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=15416a18f7645dbb9a36edb1e52f30a9e83c6627

[jszwedko]

Thanks for reporting this @senecops ! It seems to be an issue with the tool we use to build the debian packages. I opened an issue upstream: kornelski/cargo-deb#110

I noticed the only conffiles we have are in /etc though so I think we could actually drop that directive since dh_installdeb automatically flags files under /etc as conffiles. I'll open a PR to do that.