Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading Debian package to v0.33.0 overwrites configuration #18718

Closed
osalmi opened this issue Sep 29, 2023 · 1 comment · Fixed by #18726
Closed

Upgrading Debian package to v0.33.0 overwrites configuration #18718

osalmi opened this issue Sep 29, 2023 · 1 comment · Fixed by #18726
Labels
meta: regression This issue represents a regression type: bug A code related bug.
Milestone
Vector v0.33.1

Comments

@osalmi
Copy link

osalmi commented Sep 29, 2023

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

Upgrading to or reinstalling Debian package version 0.33.0-1 silently overwrites /etc/default/vector and /etc/vector/vector.yaml.

To reproduce:

  • Install Vector on Debian from the official APT repo
  • Modify /etc/default/vector or /etc/vector/vector.yaml
  • Reinstall Vector: apt-get install --reinstall vector
  • The modified file is silently overwritten with the default content from the package

Encountered on both Debian 11 and 12 hosts.

Configuration

No response

Version

vector 0.33.0 (x86_64-unknown-linux-gnu 89605fb 2023-09-27 14:18:24.180809939)

Debug Output

No response

Example Data

No response

Additional Context

No response

References
@osalmi osalmi added the type: bug A code related bug. label Sep 29, 2023
@jszwedko
Copy link
Member

Thanks for this report @osalmi . I was able to reproduce this. The linked PR does seem suspicious though dh_installdeb claims it automatically handles files written to /etc. We'll aim to fix this for v0.33.1.

@jszwedko jszwedko added this to the Vector v0.33.1 milestone Sep 29, 2023
@jszwedko jszwedko mentioned this issue Sep 29, 2023
Merged
@jszwedko jszwedko added the meta: regression This issue represents a regression label Sep 29, 2023
jszwedko added a commit that referenced this issue Sep 29, 2023
@jszwedko
chore(releasing): Add known issue for 0.33.0 debian packaging regression
43b1a6a 
Regression: #18718

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@jszwedko jszwedko mentioned this issue Sep 29, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 29, 2023
@jszwedko
chore(releasing): Add known issue for 0.33.0 debian packaging regress…
ff745ab 
…ion (#18727)

Regression: #18718

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
jszwedko added a commit that referenced this issue Oct 2, 2023
@jszwedko
chore(releasing): Add known issue for 0.33.0 debian packaging regress…
eae7b82 
…ion (#18727)

Regression: #18718

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta: regression This issue represents a regression type: bug A code related bug.
Projects
None yet
Milestone
Vector v0.33.1
Development

Successfully merging a pull request may close this issue.

fix(debian platform): Re-add conf-files directive for cargo-deb vectordotdev/vector
2 participants
@osalmi @jszwedko