Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS X users report #9699 requires minikube tunnel, breaking soaks/soak.sh #9752

Closed
Tracked by #9515
blt opened this issue Oct 21, 2021 · 0 comments · Fixed by #9773
Closed
Tracked by #9515

OS X users report #9699 requires minikube tunnel, breaking soaks/soak.sh #9752

blt opened this issue Oct 21, 2021 · 0 comments · Fixed by #9773
Labels
domain: performance Anything related to Vector's performance type: task Generic non-code related tasks

Comments

@blt
Copy link
Contributor

blt commented Oct 21, 2021

After #9699 both @001wwang and @fuchsnj note that pulling the IP for soak kube prometheus results in a minikube tunnel being created, breaking the assumptions of the soak script. Undesirable. After discussing with the team we believe the correct path forward is to mount a host directory into the cluster and read the results once we're back on the host. This implies the collector needs to be in-cluster.
@blt blt added type: task Generic non-code related tasks domain: performance Anything related to Vector's performance labels Oct 21, 2021
@blt blt changed the title OS X users report chore: Allow for localhost soak testing #9699 requires minikube tunnel, breaking soaks/soak.sh OS X users report #9699 requires minikube tunnel, breaking soaks/soak.sh Oct 21, 2021
This was referenced Oct 21, 2021
Closed
Merged
@blt blt closed this as completed in #9773 Oct 25, 2021
blt added a commit that referenced this issue Oct 25, 2021
@blt
chore: Minikube Mount Host Filesystem (#9773)
ba349ee 
This commit introduces a new in-kube observer for our soak queries, writing out
to disk what it queries. This disk we mount from the host system, allowing us to
smuggle data from the kube without need for a tunnel, hopefully. This work also
starts the process of replacing our shell soak infra with rust bits, where doing so
makes soak results more explicable.

Closes #9752

Signed-off-by: Brian L. Troutwine brian@troutwine.us
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain: performance Anything related to Vector's performance type: task Generic non-code related tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Minikube Mount Host Filesystem vectordotdev/vector
1 participant
@blt