chore(ci): Remove --nocapture from integration tests
#13128
Conversation
This broke with the upgrade to `cargo nextest` 0.9.19 which wants you to use an extra `--` to pass along extra flags to the test binary, but it occurred to me that I don't think we need this flag. It's useful for debugging, but otherwise we don't really need to see the integration test output unless it fails, in which case it will output it. Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
jszwedko
added
the
ci-condition: integration tests enable
✅ Deploy Preview for vector-project ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
the
domain: ci
Signed-off-by: Toby Lawrence <toby@nuclearfurnace.com>
|
Merging since integration tests passed. |
|
Hey, apologies for breaking you! Are you sure |
|
Hey @sunshowers ! No worries, you might very well be right that it wasn't working correctly before. I know |
Soak Test ResultsBaseline: f75dbb7 ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%: Fine details of change detection per experiment.
|
This broke with the upgrade to `cargo nextest` 0.9.19 which wants you to use an extra `--` to pass along extra flags to the test binary, but it occurred to me that I don't think we need this flag. It's useful for debugging, but otherwise we don't really need to see the integration test output unless it fails, in which case it will output it. Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
This broke with the upgrade to `cargo nextest` 0.9.19 which wants you to use an extra `--` to pass along extra flags to the test binary, but it occurred to me that I don't think we need this flag. It's useful for debugging, but otherwise we don't really need to see the integration test output unless it fails, in which case it will output it. Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
This broke with the upgrade to
cargo nextest0.9.19 which wants you touse an extra
--to pass along extra flags to the test binary, but itoccurred to me that I don't think we need this flag. It's useful for
debugging, but otherwise we don't really need to see the integration
test output unless it fails, in which case it will output it.
Signed-off-by: Jesse Szwedko jesse@szwedko.me