Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(pulsar sink): Add end-to-end acknowledgements support #13744

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

bruceg
Copy link
Member

@bruceg bruceg commented Jul 27, 2022

If only they were all this easy.

Closes #13743

@bruceg bruceg added type: enhancement A value-adding code change that enhances its existing functionality. sink: pulsar Anything `pulsar` sink related labels Jul 27, 2022
@bruceg bruceg self-assigned this Jul 27, 2022
@netlify
Copy link

netlify bot commented Jul 27, 2022

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit 410a42e
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/62e1d10ff4bedd0009dbc7b5
😎 Deploy Preview https://deploy-preview-13744--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added domain: external docs Anything related to Vector's external, public documentation domain: sinks Anything related to the Vector's sinks labels Jul 27, 2022
@github-actions
Copy link

Soak Test Results

Baseline: b838a19
Comparison: 410a42e
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
http_pipelines_blackhole_acks 21.87KiB 1.9 100.00% 1.12MiB 126.58KiB 2.58KiB 0 0.109997 1.14MiB 100.82KiB 2.06KiB 0 0.0859788 False False
syslog_log2metric_humio_metrics 93.26KiB 0.7 100.00% 12.94MiB 284.52KiB 5.81KiB 0 0.0214722 13.03MiB 472.3KiB 9.62KiB 0 0.035394 False False
syslog_regex_logs2metric_ddmetrics 46.27KiB 0.36 99.08% 12.6MiB 653.2KiB 13.3KiB 0 0.0506188 12.64MiB 576.92KiB 11.76KiB 0 0.0445477 False False
socket_to_socket_blackhole 41.02KiB 0.29 100.00% 13.76MiB 157.66KiB 3.22KiB 0 0.0111868 13.8MiB 113.7KiB 2.32KiB 0 0.00804425 False False
splunk_hec_to_splunk_hec_logs_noack 20.41KiB 0.08 89.72% 23.82MiB 515.74KiB 10.52KiB 0 0.0211428 23.84MiB 330.83KiB 6.75KiB 0 0.0135509 False False
splunk_hec_indexer_ack_blackhole 16.89KiB 0.07 50.87% 23.76MiB 886.48KiB 18.04KiB 0 0.036431 23.77MiB 817.33KiB 16.64KiB 0 0.0335661 False False
http_text_to_http_json 24.84KiB 0.06 69.38% 38.79MiB 886.59KiB 18.1KiB 0 0.0223183 38.81MiB 792.41KiB 16.17KiB 0 0.0199349 False False
splunk_hec_route_s3 -2.57KiB -0.01 3.12% 19.09MiB 2.29MiB 47.61KiB 0 0.119792 19.09MiB 2.16MiB 45.25KiB 0 0.113361 False False
enterprise_http_to_http -1.96KiB -0.01 21.68% 23.85MiB 242.57KiB 4.95KiB 0 0.00993149 23.85MiB 251.3KiB 5.14KiB 0 0.0102898 False False
file_to_blackhole -26.95KiB -0.03 21.68% 95.34MiB 3.41MiB 70.77KiB 0 0.0357987 95.32MiB 3.26MiB 67.71KiB 0 0.0341552 False False
syslog_splunk_hec_logs -12.57KiB -0.07 42.03% 16.53MiB 832.53KiB 16.95KiB 0 0.0491681 16.52MiB 739.78KiB 15.09KiB 0 0.0437228 False False
splunk_hec_to_splunk_hec_logs_acks -20.98KiB -0.09 64.04% 23.77MiB 744.06KiB 15.15KiB 0 0.0305569 23.75MiB 844.02KiB 17.17KiB 0 0.0346917 False False
fluent_elasticsearch -122.5KiB -0.15 100.00% 79.47MiB 52.42KiB 1.06KiB 0 0.000644059 79.35MiB 1.17MiB 24.16KiB 0 0.0147776 False False
http_to_http_json -46.39KiB -0.19 99.93% 23.85MiB 345.07KiB 7.04KiB 0 0.0141286 23.8MiB 571.33KiB 11.65KiB 0 0.0234368 False False
syslog_humio_logs -38.6KiB -0.22 100.00% 16.84MiB 315.17KiB 6.43KiB 0 0.0182778 16.8MiB 330.4KiB 6.76KiB 0 0.0192035 False False
http_to_http_noack -60.13KiB -0.25 97.85% 23.81MiB 689.0KiB 14.07KiB 0 0.0282516 23.75MiB 1.06MiB 22.03KiB 0 0.04447 False False
datadog_agent_remap_datadog_logs -299.32KiB -0.46 99.25% 62.91MiB 2.63MiB 55.19KiB 0 0.0418488 62.62MiB 4.67MiB 97.34KiB 0 0.0746043 False False
syslog_log2metric_splunk_hec_metrics -101.0KiB -0.55 99.96% 17.87MiB 888.49KiB 18.11KiB 0 0.0485519 17.77MiB 1.05MiB 21.83KiB 0 0.0589842 False False
http_pipelines_no_grok_blackhole -80.98KiB -0.71 99.95% 11.06MiB 268.24KiB 5.47KiB 0 0.0236711 10.98MiB 1.09MiB 22.74KiB 0 0.0994176 False False
datadog_agent_remap_datadog_logs_acks -879.57KiB -1.37 100.00% 62.56MiB 3.96MiB 82.74KiB 0 0.063237 61.7MiB 5.4MiB 112.38KiB 0 0.0874845 False False
datadog_agent_remap_blackhole_acks -944.04KiB -1.53 100.00% 60.22MiB 5.63MiB 117.27KiB 0 0.0934904 59.3MiB 5.33MiB 111.5KiB 0 0.0898215 False False
http_to_http_acks -345.76KiB -1.85 85.03% 18.3MiB 7.84MiB 164.01KiB 0 0.428638 17.96MiB 8.39MiB 175.18KiB 0 0.466828 True True
syslog_loki -329.95KiB -2.25 100.00% 14.32MiB 519.44KiB 10.63KiB 0 0.0354173 14.0MiB 781.89KiB 15.89KiB 0 0.0545399 False False
datadog_agent_remap_blackhole -1.6MiB -2.5 100.00% 63.99MiB 4.24MiB 88.43KiB 0 0.0663258 62.39MiB 4.78MiB 99.65KiB 0 0.0765642 False False
http_pipelines_blackhole -62.19KiB -3.77 100.00% 1.61MiB 82.36KiB 1.68KiB 0 0.0498537 1.55MiB 156.46KiB 3.19KiB 0 0.0984146 False False

Copy link
Contributor

@spencergilbert spencergilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@bruceg bruceg merged commit 975b99c into master Jul 28, 2022
@bruceg bruceg deleted the pulsar-acknowledgements branch July 28, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation domain: sinks Anything related to the Vector's sinks sink: pulsar Anything `pulsar` sink related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for end-to-end acknowledgements to pulsar sink
2 participants