fix(http sink): cert verification with proxy enabled #13759
Conversation
…fic certificate settings
|
|
✅ Deploy Preview for vector-project canceled.
|
|
@ntim Thanks for that. Given that it looks like the tests are passing/should pass without issue, the only remaining bit is signing our CLA. 🖊️ 📜 |
tobz
added
the
ci-condition: integration tests enable
Soak Test ResultsBaseline: 4a14553 ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%: Fine details of change detection per experiment.
|
Soak Test ResultsBaseline: 7d9e3e6 ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%: Fine details of change detection per experiment.
|
|
The failed integration tests we can ignore: they depend on secret credentials that aren't injected into CI workflows based on outside forks. I'm just rerunning the unit tests for macOS, as there was a weird test failure that had some TLS-related output. Might be a red herring, since it didn't fail for any other platforms, but we'll see. |
|
Gonna try the macOS unit tests one more time then try and debug it locally... still not sure what's up since those unit tests don't appear to use proxying or TLS in any way. 🤔 |
|
Looks like it was indeed a bit flaky. Thanks again for your contribution! |
As described in #13683, when enabling the proxy for the http sink, the hyper ProxyConnector is not configured properly with the user supplied tls settings. Therefore, certificate verification using a private PKI or client cert authentication are broken.