Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(pulsar sink)Support pulsar topics lookup retry options #14779

Conversation

tuteng
Copy link

@tuteng tuteng commented Oct 9, 2022

enhancement: Support retry option when configuring topic lookup

@bits-bot
Copy link

bits-bot commented Oct 9, 2022

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Oct 9, 2022

Deploy Preview for vector-project canceled.

Name Link
🔨 Latest commit 4829341
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/63455ed1299f3a000912d546

@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Oct 9, 2022
@tuteng tuteng changed the title Support pulsar topics lookup retry options [enhancement][pulsar sink]Support pulsar topics lookup retry options Oct 9, 2022
@tuteng tuteng changed the title [enhancement][pulsar sink]Support pulsar topics lookup retry options enhancement(pulsar sink)Support pulsar topics lookup retry options Oct 9, 2022
@tuteng
Copy link
Author

tuteng commented Oct 11, 2022

Anyone help review this pr? thanks

@neuronull
Copy link
Contributor

👋 Hi @tuteng !

We have a rather uncommon situation on our hands.

There is a separate contributor PR (#14345) , which is refactoring the pulsar sink to be in the "new style" framework.

That change would overwrite your proposed changes here.

Since we are striving to get all sinks to be in this new-style, and since this new-style framework has provisions for exposing the retry logic already, I have asked the author of #14345 to include the respective changes to that effect.

If for some reason that doesn't happen, it would be a small PR similar to this size or smaller, to enable that.

@jszwedko jszwedko requested review from a team and removed request for a team October 26, 2022 17:32
@tuteng
Copy link
Author

tuteng commented Nov 18, 2022

Repeat with #14345, so closed it

@tuteng tuteng closed this Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sinks Anything related to the Vector's sinks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants