Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): Add Log Namespacing docs #16571
chore(docs): Add Log Namespacing docs #16571
Changes from 21 commits
287a3df
a204d30
5cc4988
cf3e1bc
c21cbb1
6314517
12c73c9
8661cbf
730ec6e
bc31985
c590b7a
f7d95a8
1faac62
e91a32f
3965bdc
ca90422
c77ff54
415c215
4cdd37a
f989f0c
af93a41
5a20ea9
40bd4d6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently in Remap, even with Log Namespacing, if you assign
.
to a non object or array value it will place that value under themessage
field.We should either change it so it assigns the value to root in the Vector namespace, or call that out in the docs here. I'm in favour of the former.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm working on making this change. Will have a new PR up shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#17807