Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(vdev): Load compose files and inject network block #17025
enhancement(vdev): Load compose files and inject network block #17025
Changes from 4 commits
9e6de82
fc15fbd
537049b
06433ab
1209010
7b7a346
1562ad7
a9df591
e1bef44
317da52
76a9b97
0dd377a
54aacd0
1a64739
cc03e3c
ba1f01f
e69623b
6a7e226
612e1e0
eacf027
cd1e267
4b0260e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was under the assumption that
image
was required, in what case can it beNone
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might have been an artifact of me being copy pasta happy with that line above and putting it over even fields that are required or guaranteed to be included.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah but in this case it was added because
cargo vdev integration start dnstap
would fail if making the image field a String instead of an optionscripts/integration/dnstap/compose.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noting that
image
isn't required when defining the test runner service, which builds from the local source.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it is required to capture and recreate the
image
parameter already existing in the compose files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, yeah I was just adding a case example to Spencer's earlier question, could have quoted that