fix(elasticsearch sink): Elasticsearch sink with api_version set to "auto" does not recognize the API version of ES6 as V6 (#17226) #17227

syedriko · 2023-04-27T04:14:55Z

fix(elasticsearch sink): Elasticsearch sink with api_version set to "auto" does not recognize the API version of ES6 as V6 (#17226)

bits-bot · 2023-04-27T04:14:59Z

All committers have signed the CLA.

netlify · 2023-04-27T04:15:02Z

✅ Deploy Preview for vrl-playground canceled.

Name	Link
🔨 Latest commit	`13be8fd`
🔍 Latest deploy log	https://app.netlify.com/sites/vrl-playground/deploys/645027b61e85c7000808f185

netlify · 2023-04-27T04:15:03Z

✅ Deploy Preview for vector-project canceled.

Name	Link
🔨 Latest commit	`13be8fd`
🔍 Latest deploy log	https://app.netlify.com/sites/vector-project/deploys/645027b695824d0008c378ec

spencergilbert

Thank you this contribution! Definitely seems like we're missing test coverage on this as well, so thank you for surfacing that as well 🙂

It looks like we could cut out one of the structs, or at least rename it. What do you think @syedriko?

spencergilbert · 2023-04-28T20:12:57Z

src/sinks/elasticsearch/common.rs

+    #[derive(Deserialize)]
+    struct Version {
+        number: Option<String>,
+    }
    #[derive(Deserialize)]
    struct ClusterState {


This seems incorrectly named given the changes, I'm also not sure if we need an additional struct or just the version.number?

I think this is right, at least the structure, since the version number is nested this way.

Mhmm, yea - I don't see a name for that API, so maybe Response is fine?

Thanks for the feedback! response was already taken so I renamed ClusterState to ResponsePayload. Couldn't find the name of that API either. If there's a more concise way to express the shape of that payload for serde, I'm all for it. I also added a debug!() log statement for the auto-detected API version.

github-actions · 2023-05-01T14:13:28Z

Regression Detector Results

Run ID: 70824917-2929-4cc2-a044-89c6080bfa40
Baseline: 41ac76e
Comparison: 8a336f0
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.
Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.

experiment	goal	Δ mean %	Δ mean % CI	confidence
http_text_to_http_json	ingress throughput	+3.58	[+3.51, +3.66]	100.00%
syslog_regex_logs2metric_ddmetrics	ingress throughput	+2.95	[+2.71, +3.18]	100.00%
datadog_agent_remap_datadog_logs	ingress throughput	+1.84	[+1.74, +1.95]	100.00%
datadog_agent_remap_blackhole	ingress throughput	+0.94	[+0.87, +1.02]	100.00%
datadog_agent_remap_datadog_logs_acks	ingress throughput	+0.60	[+0.51, +0.69]	100.00%
syslog_loki	ingress throughput	+0.53	[+0.46, +0.61]	100.00%
enterprise_http_to_http	ingress throughput	+0.04	[+0.01, +0.08]	88.18%
http_to_http_noack	ingress throughput	+0.03	[-0.03, +0.09]	49.13%
file_to_blackhole	ingress throughput	+0.01	[-0.04, +0.06]	22.16%
splunk_hec_indexer_ack_blackhole	ingress throughput	-0.00	[-0.04, +0.04]	0.15%
fluent_elasticsearch	ingress throughput	-0.00	[-0.00, +0.00]	35.33%
splunk_hec_to_splunk_hec_logs_noack	ingress throughput	-0.01	[-0.05, +0.04]	17.87%
splunk_hec_to_splunk_hec_logs_acks	ingress throughput	-0.01	[-0.07, +0.05]	17.19%
syslog_splunk_hec_logs	ingress throughput	-0.63	[-0.69, -0.56]	100.00%
http_to_http_json	ingress throughput	-0.75	[-0.81, -0.69]	100.00%
datadog_agent_remap_blackhole_acks	ingress throughput	-0.87	[-0.96, -0.77]	100.00%
http_to_http_acks	ingress throughput	-0.89	[-2.12, +0.34]	64.48%
splunk_hec_route_s3	ingress throughput	-1.36	[-1.49, -1.23]	100.00%
syslog_humio_logs	ingress throughput	-1.54	[-1.60, -1.47]	100.00%
socket_to_socket_blackhole	ingress throughput	-1.87	[-1.91, -1.82]	100.00%
otlp_grpc_to_blackhole	ingress throughput	-1.89	[-2.00, -1.78]	100.00%
syslog_log2metric_splunk_hec_metrics	ingress throughput	-2.85	[-2.93, -2.77]	100.00%
syslog_log2metric_humio_metrics	ingress throughput	-2.91	[-3.01, -2.81]	100.00%
otlp_http_to_blackhole	ingress throughput	-4.11	[-4.26, -3.96]	100.00%

spencergilbert

Awesome, thank you! Two suggestions to get CI green.

src/sinks/elasticsearch/common.rs

github-actions · 2023-05-01T20:26:22Z

Regression Detector Results

Run ID: 2580fd0c-fd9d-413d-ae97-5e54d713469f
Baseline: 7570bb3
Comparison: 80ce4b3
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.
Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

Changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%:

experiment	goal	Δ mean %	confidence
splunk_hec_to_splunk_hec_logs_acks	ingress throughput	-9.72	100.00%

Fine details of change detection per experiment.

experiment	goal	Δ mean %	Δ mean % CI	confidence
http_text_to_http_json	ingress throughput	+2.50	[+2.43, +2.58]	100.00%
datadog_agent_remap_datadog_logs	ingress throughput	+1.50	[+1.40, +1.61]	100.00%
datadog_agent_remap_datadog_logs_acks	ingress throughput	+0.96	[+0.86, +1.06]	100.00%
splunk_hec_route_s3	ingress throughput	+0.95	[+0.82, +1.09]	100.00%
datadog_agent_remap_blackhole	ingress throughput	+0.88	[+0.79, +0.97]	100.00%
syslog_loki	ingress throughput	+0.19	[+0.09, +0.30]	97.95%
enterprise_http_to_http	ingress throughput	+0.03	[-0.01, +0.07]	67.43%
file_to_blackhole	ingress throughput	+0.03	[-0.02, +0.08]	50.58%
fluent_elasticsearch	ingress throughput	+0.00	[-0.00, +0.00]	33.54%
splunk_hec_indexer_ack_blackhole	ingress throughput	-0.02	[-0.06, +0.02]	49.46%
splunk_hec_to_splunk_hec_logs_noack	ingress throughput	-0.03	[-0.08, +0.01]	65.43%
syslog_splunk_hec_logs	ingress throughput	-0.04	[-0.11, +0.03]	49.68%
http_to_http_noack	ingress throughput	-0.04	[-0.10, +0.02]	59.07%
syslog_log2metric_splunk_hec_metrics	ingress throughput	-0.10	[-0.16, -0.03]	92.99%
http_to_http_json	ingress throughput	-0.56	[-0.62, -0.50]	100.00%
datadog_agent_remap_blackhole_acks	ingress throughput	-0.72	[-0.84, -0.61]	100.00%
http_to_http_acks	ingress throughput	-1.06	[-2.27, +0.15]	73.93%
syslog_log2metric_humio_metrics	ingress throughput	-1.19	[-1.30, -1.09]	100.00%
syslog_humio_logs	ingress throughput	-2.12	[-2.21, -2.03]	100.00%
socket_to_socket_blackhole	ingress throughput	-2.51	[-2.57, -2.45]	100.00%
otlp_grpc_to_blackhole	ingress throughput	-2.60	[-2.72, -2.48]	100.00%
syslog_regex_logs2metric_ddmetrics	ingress throughput	-3.36	[-3.58, -3.14]	100.00%
otlp_http_to_blackhole	ingress throughput	-4.94	[-5.10, -4.78]	100.00%
splunk_hec_to_splunk_hec_logs_acks	ingress throughput	-9.72	[-10.21, -9.24]	100.00%

…auto" does not recognize the API version of ES6 as V6 (vectordotdev#17226)

github-actions · 2023-05-01T23:36:33Z

Regression Detector Results

Run ID: c9537e58-b4cc-409c-a39c-f92b5e80c0af
Baseline: 7570bb3
Comparison: 13be8fd
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.
Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

Changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%:

experiment	goal	Δ mean %	confidence
syslog_humio_logs	ingress throughput	+6.13	100.00%

Fine details of change detection per experiment.

experiment	goal	Δ mean %	Δ mean % CI	confidence
syslog_humio_logs	ingress throughput	+6.13	[+5.68, +6.57]	100.00%
http_text_to_http_json	ingress throughput	+4.41	[+4.34, +4.48]	100.00%
syslog_regex_logs2metric_ddmetrics	ingress throughput	+4.27	[+4.00, +4.54]	100.00%
splunk_hec_route_s3	ingress throughput	+2.60	[+2.48, +2.72]	100.00%
datadog_agent_remap_datadog_logs	ingress throughput	+2.15	[+2.02, +2.28]	100.00%
syslog_log2metric_humio_metrics	ingress throughput	+0.99	[+0.88, +1.10]	100.00%
datadog_agent_remap_datadog_logs_acks	ingress throughput	+0.74	[+0.64, +0.84]	100.00%
http_to_http_json	ingress throughput	+0.06	[+0.01, +0.11]	86.41%
file_to_blackhole	ingress throughput	+0.06	[+0.01, +0.11]	85.07%
http_to_http_noack	ingress throughput	+0.05	[-0.01, +0.10]	71.63%
enterprise_http_to_http	ingress throughput	+0.03	[-0.00, +0.06]	75.42%
fluent_elasticsearch	ingress throughput	-0.00	[-0.00, -0.00]	92.80%
splunk_hec_to_splunk_hec_logs_acks	ingress throughput	-0.00	[-0.07, +0.06]	4.93%
splunk_hec_to_splunk_hec_logs_noack	ingress throughput	-0.01	[-0.05, +0.04]	18.87%
splunk_hec_indexer_ack_blackhole	ingress throughput	-0.01	[-0.06, +0.03]	30.85%
syslog_splunk_hec_logs	ingress throughput	-0.19	[-0.26, -0.12]	99.95%
http_to_http_acks	ingress throughput	-0.69	[-1.90, +0.52]	53.36%
datadog_agent_remap_blackhole	ingress throughput	-1.76	[-1.83, -1.69]	100.00%
datadog_agent_remap_blackhole_acks	ingress throughput	-1.87	[-2.00, -1.75]	100.00%
otlp_grpc_to_blackhole	ingress throughput	-2.02	[-2.13, -1.91]	100.00%
syslog_loki	ingress throughput	-2.13	[-2.20, -2.07]	100.00%
syslog_log2metric_splunk_hec_metrics	ingress throughput	-2.47	[-2.57, -2.37]	100.00%
socket_to_socket_blackhole	ingress throughput	-3.57	[-3.62, -3.51]	100.00%
otlp_http_to_blackhole	ingress throughput	-4.28	[-4.45, -4.11]	100.00%

spencergilbert

Thanks for the fix!

# [1.13.0](answerbook/vector@v1.12.1...v1.13.0) (2023-09-13) ### Bug Fixes * **appsignal sink**: Add TLS config option (vectordotdev#17122) [198068c](answerbook/vector@198068c) - GitHub * **buffers**: correctly handle partial writes in reader seek during initialization (vectordotdev#17099) [a791595](answerbook/vector@a791595) - GitHub * **config**: recurse through schema refs when determining eligibility for unevaluated properties (vectordotdev#17150) [71d1bf6](answerbook/vector@71d1bf6) - GitHub * **docker_logs source**: Support tcp schema [e1c0c02](answerbook/vector@e1c0c02) - GitHub * **elasticsearch sink**: Elasticsearch sink with api_version set to "auto" does not recognize the API version of ES6 as V6 (vectordotdev#17226) (vectordotdev#17227) [9b6ef24](answerbook/vector@9b6ef24) - GitHub * **gcp_stackdriver_metrics sink**: Call function to regenerate auth token (vectordotdev#17297) [bf7904b](answerbook/vector@bf7904b) - GitHub * **influxdb_logs**: encode influx line when no tags present (vectordotdev#17029) [c3aa14f](answerbook/vector@c3aa14f) - GitHub * **reduce transform**: Revert flushing on interval change to `expire_metrics_ms` (vectordotdev#17084) [e86b155](answerbook/vector@e86b155) - GitHub * **releasing**: Fix globbing of release artifacts for GitHub (vectordotdev#17114) [7fe089c](answerbook/vector@7fe089c) - GitHub * **schemas**: Dont panic with non object field kinds (vectordotdev#17140) [1e43208](answerbook/vector@1e43208) - GitHub ### Chores * (syslog source): add source_ip to some syslog tests (vectordotdev#17235) [29c34c0](answerbook/vector@29c34c0) - GitHub * add note to DEVELOPING.md re panics (vectordotdev#17277) [03e905e](answerbook/vector@03e905e) - GitHub * Add UX note about encoding of log_schema keys (vectordotdev#17266) [dc6e54c](answerbook/vector@dc6e54c) - GitHub * **administration**: add `appsignal` to codeowners (vectordotdev#17127) [7b15d19](answerbook/vector@7b15d19) - GitHub * **buffer**: tidy up some of the module level docs for `disk_v2` (vectordotdev#17093) [edaa612](answerbook/vector@edaa612) - GitHub * **ci**: bump docker/metadata-action from 4.3.0 to 4.4.0 (vectordotdev#17170) [854d71e](answerbook/vector@854d71e) - GitHub * **ci**: Disable `appsignal` integration test until CA issues are resolved (vectordotdev#17109) [f3b5d42](answerbook/vector@f3b5d42) - GitHub * **ci**: Disable scheduled runs of Baseline Timings workflow (vectordotdev#17281) [4335b0a](answerbook/vector@4335b0a) - GitHub * **ci**: Fix event assertions for `aws_ec2_metadata` transform (vectordotdev#17413) [da36fb6](answerbook/vector@da36fb6) - GitHub * **ci**: Increase timeout for integration tests (vectordotdev#17326) [e1f125a](answerbook/vector@e1f125a) - GitHub * **ci**: Increase timeout for integration tests to 30m (vectordotdev#17350) [5d3f619](answerbook/vector@5d3f619) - GitHub * **ci**: re-enable `appsignal` integration test (vectordotdev#17111) [48fc574](answerbook/vector@48fc574) - GitHub * **ci**: Remove ci-sweep tasks (vectordotdev#17415) [5c33f99](answerbook/vector@5c33f99) - GitHub * **ci**: remove unnecessary dep install (vectordotdev#17128) [f56d1ef](answerbook/vector@f56d1ef) - GitHub * **ci**: Try to fix apt retries (vectordotdev#17393) [6b3db04](answerbook/vector@6b3db04) - GitHub * **ci**: update unsupported ubuntu version runners (vectordotdev#17113) [e7c4815](answerbook/vector@e7c4815) - GitHub * **ci**: use python v3.8 in ubuntu 20.04 runner (vectordotdev#17116) [7a40c81](answerbook/vector@7a40c81) - GitHub * **config**: begin laying out primitives for programmatically querying schema (vectordotdev#17130) [aad8115](answerbook/vector@aad8115) - GitHub * **config**: emit human-friendly version of enum variant/property names in schema (vectordotdev#17171) [3b38ba8](answerbook/vector@3b38ba8) - GitHub * **config**: improve config schema output with more precise `unevaluatedProperties` + schema ref flattening (vectordotdev#17026) [2d72f82](answerbook/vector@2d72f82) - GitHub * **deps**: Add 3rd party license file and CI checks (vectordotdev#17344) [7350e1a](answerbook/vector@7350e1a) - GitHub * **deps**: bump anyhow from 1.0.70 to 1.0.71 (vectordotdev#17300) [6a5af3b](answerbook/vector@6a5af3b) - GitHub * **deps**: bump assert_cmd from 2.0.10 to 2.0.11 (vectordotdev#17290) [c4784fd](answerbook/vector@c4784fd) - GitHub * **deps**: bump async-compression from 0.3.15 to 0.4.0 (vectordotdev#17365) [b9aac47](answerbook/vector@b9aac47) - GitHub * **deps**: bump async-graphql from 5.0.7 to 5.0.8 (vectordotdev#17357) [05a4f17](answerbook/vector@05a4f17) - GitHub * **deps**: bump async-graphql-warp from 5.0.7 to 5.0.8 (vectordotdev#17367) [693584e](answerbook/vector@693584e) - GitHub * **deps**: bump async-stream from 0.3.4 to 0.3.5 (vectordotdev#17076) [c29c817](answerbook/vector@c29c817) - GitHub * **deps**: bump aws-sigv4 from 0.55.0 to 0.55.1 (vectordotdev#17138) [dbb3f25](answerbook/vector@dbb3f25) - GitHub * **deps**: bump axum from 0.6.12 to 0.6.18 (vectordotdev#17257) [41ac76e](answerbook/vector@41ac76e) - GitHub * **deps**: bump cached from 0.42.0 to 0.43.0 (vectordotdev#17118) [f90b3b3](answerbook/vector@f90b3b3) - GitHub * **deps**: bump chrono-tz from 0.8.1 to 0.8.2 (vectordotdev#17088) [623b838](answerbook/vector@623b838) - GitHub * **deps**: bump clap_complete from 4.2.0 to 4.2.1 (vectordotdev#17229) [d286d16](answerbook/vector@d286d16) - GitHub * **deps**: bump clap_complete from 4.2.1 to 4.2.2 (vectordotdev#17359) [565668e](answerbook/vector@565668e) - GitHub * **deps**: bump clap_complete from 4.2.2 to 4.2.3 (vectordotdev#17383) [111cd07](answerbook/vector@111cd07) - GitHub * **deps**: bump console-subscriber from 0.1.8 to 0.1.9 (vectordotdev#17358) [97b862c](answerbook/vector@97b862c) - GitHub * **deps**: bump directories from 5.0.0 to 5.0.1 (vectordotdev#17271) [be69f5f](answerbook/vector@be69f5f) - GitHub * **deps**: bump dunce from 1.0.3 to 1.0.4 (vectordotdev#17244) [cfc387d](answerbook/vector@cfc387d) - GitHub * **deps**: bump enumflags2 from 0.7.5 to 0.7.6 (vectordotdev#17079) [cbc17be](answerbook/vector@cbc17be) - GitHub * **deps**: bump enumflags2 from 0.7.6 to 0.7.7 (vectordotdev#17206) [c80c5eb](answerbook/vector@c80c5eb) - GitHub * **deps**: bump flate2 from 1.0.25 to 1.0.26 (vectordotdev#17320) [ef13370](answerbook/vector@ef13370) - GitHub * **deps**: bump getrandom from 0.2.8 to 0.2.9 (vectordotdev#17101) [d53240b](answerbook/vector@d53240b) - GitHub * **deps**: bump h2 from 0.3.18 to 0.3.19 (vectordotdev#17388) [6088abd](answerbook/vector@6088abd) - GitHub * **deps**: bump hashlink from 0.8.1 to 0.8.2 (vectordotdev#17419) [01b3cd7](answerbook/vector@01b3cd7) - GitHub * **deps**: bump hyper from 0.14.25 to 0.14.26 (vectordotdev#17347) [c43dcfd](answerbook/vector@c43dcfd) - GitHub * **deps**: bump inventory from 0.3.5 to 0.3.6 (vectordotdev#17401) [5b5ad16](answerbook/vector@5b5ad16) - GitHub * **deps**: bump libc from 0.2.140 to 0.2.141 (vectordotdev#17104) [dd9608a](answerbook/vector@dd9608a) - GitHub * **deps**: bump libc from 0.2.141 to 0.2.142 (vectordotdev#17273) [bc618a2](answerbook/vector@bc618a2) - GitHub * **deps**: bump libc from 0.2.142 to 0.2.143 (vectordotdev#17338) [6afe206](answerbook/vector@6afe206) - GitHub * **deps**: bump libc from 0.2.143 to 0.2.144 (vectordotdev#17346) [99b8dc1](answerbook/vector@99b8dc1) - GitHub * **deps**: bump memmap2 from 0.5.10 to 0.6.0 (vectordotdev#17355) [dae0c6a](answerbook/vector@dae0c6a) - GitHub * **deps**: bump memmap2 from 0.6.0 to 0.6.1 (vectordotdev#17364) [58ba741](answerbook/vector@58ba741) - GitHub * **deps**: bump metrics, metrics-tracing-context, metrics-util (vectordotdev#17336) [9a723e3](answerbook/vector@9a723e3) - GitHub * **deps**: bump mlua from 0.8.8 to 0.8.9 (vectordotdev#17423) [57f8bd4](answerbook/vector@57f8bd4) - GitHub * **deps**: bump mock_instant from 0.2.1 to 0.3.0 (vectordotdev#17210) [40c9afc](answerbook/vector@40c9afc) - GitHub * **deps**: bump mongodb from 2.4.0 to 2.5.0 (vectordotdev#17337) [64f4f69](answerbook/vector@64f4f69) - GitHub * **deps**: bump nkeys from 0.2.0 to 0.3.0 (vectordotdev#17421) [3320eda](answerbook/vector@3320eda) - GitHub * **deps**: bump notify from 5.1.0 to 6.0.0 (vectordotdev#17422) [58603b9](answerbook/vector@58603b9) - GitHub * **deps**: bump num_enum from 0.5.11 to 0.6.0 (vectordotdev#17106) [42f298b](answerbook/vector@42f298b) - GitHub * **deps**: bump num_enum from 0.6.0 to 0.6.1 (vectordotdev#17272) [f696e7b](answerbook/vector@f696e7b) - GitHub * **deps**: bump opendal from 0.30.5 to 0.31.0 (vectordotdev#17119) [8762563](answerbook/vector@8762563) - GitHub * **deps**: bump opendal from 0.31.0 to 0.33.2 (vectordotdev#17286) [3d41931](answerbook/vector@3d41931) - GitHub * **deps**: bump opendal from 0.33.2 to 0.34.0 (vectordotdev#17354) [ae602da](answerbook/vector@ae602da) - GitHub * **deps**: bump openssl from 0.10.48 to 0.10.50 (vectordotdev#17087) [9a56ed8](answerbook/vector@9a56ed8) - GitHub * **deps**: bump openssl from 0.10.50 to 0.10.52 (vectordotdev#17299) [0ecceb3](answerbook/vector@0ecceb3) - GitHub * **deps**: bump pin-project from 1.0.12 to 1.1.0 (vectordotdev#17385) [e8d3002](answerbook/vector@e8d3002) - GitHub * **deps**: bump prettydiff from 0.6.2 to 0.6.4 (vectordotdev#17089) [e090610](answerbook/vector@e090610) - GitHub * **deps**: bump prettydiff from 0.6.2 to 0.6.4 (vectordotdev#17315) [a1ec68d](answerbook/vector@a1ec68d) - GitHub * **deps**: bump proc-macro2 from 1.0.55 to 1.0.56 (vectordotdev#17103) [6f74523](answerbook/vector@6f74523) - GitHub * **deps**: bump proc-macro2 from 1.0.56 to 1.0.57 (vectordotdev#17400) [a6e1ae7](answerbook/vector@a6e1ae7) - GitHub * **deps**: bump prost-build from 0.11.8 to 0.11.9 (vectordotdev#17260) [a88aba4](answerbook/vector@a88aba4) - GitHub * **deps**: bump quote from 1.0.26 to 1.0.27 (vectordotdev#17348) [f81ff18](answerbook/vector@f81ff18) - GitHub * **deps**: bump rdkafka from 0.29.0 to 0.30.0 (vectordotdev#17387) [9703188](answerbook/vector@9703188) - GitHub * **deps**: bump regex from 1.7.3 to 1.8.1 (vectordotdev#17222) [410aa3c](answerbook/vector@410aa3c) - GitHub * **deps**: bump reqwest from 0.11.16 to 0.11.17 (vectordotdev#17316) [09176ec](answerbook/vector@09176ec) - GitHub * **deps**: bump security-framework from 2.8.2 to 2.9.0 (vectordotdev#17386) [1287168](answerbook/vector@1287168) - GitHub * **deps**: bump serde from 1.0.159 to 1.0.160 (vectordotdev#17270) [036ad4a](answerbook/vector@036ad4a) - GitHub * **deps**: bump serde from 1.0.160 to 1.0.162 (vectordotdev#17317) [79e97a2](answerbook/vector@79e97a2) - GitHub * **deps**: bump serde from 1.0.162 to 1.0.163 (vectordotdev#17366) [9852c17](answerbook/vector@9852c17) - GitHub * **deps**: bump serde_json from 1.0.95 to 1.0.96 (vectordotdev#17258) [7570bb3](answerbook/vector@7570bb3) - GitHub * **deps**: bump serde_with from 2.3.1 to 2.3.2 (vectordotdev#17090) [adbf4d5](answerbook/vector@adbf4d5) - GitHub * **deps**: bump serde_yaml from 0.9.19 to 0.9.21 (vectordotdev#17120) [d6f2625](answerbook/vector@d6f2625) - GitHub * **deps**: bump socket2 from 0.4.7 to 0.5.2 (vectordotdev#17121) [db39d83](answerbook/vector@db39d83) - GitHub * **deps**: bump socket2 from 0.5.2 to 0.5.3 (vectordotdev#17384) [ac51b8a](answerbook/vector@ac51b8a) - GitHub * **deps**: bump syslog from 6.0.1 to 6.1.0 (vectordotdev#17301) [61e6154](answerbook/vector@61e6154) - GitHub * **deps**: bump tokio from 1.27.0 to 1.28.0 (vectordotdev#17231) [8067f84](answerbook/vector@8067f84) - GitHub * **deps**: bump tokio from 1.28.0 to 1.28.1 (vectordotdev#17368) [ae6a51b](answerbook/vector@ae6a51b) - GitHub * **deps**: bump tokio-stream from 0.1.12 to 0.1.14 (vectordotdev#17339) [80c8247](answerbook/vector@80c8247) - GitHub * **deps**: bump tokio-tungstenite from 0.18.0 to 0.19.0 (vectordotdev#17404) [ae1dd6e](answerbook/vector@ae1dd6e) - GitHub * **deps**: bump tonic from 0.8.3 to 0.9.1 (vectordotdev#17077) [eafba69](answerbook/vector@eafba69) - GitHub * **deps**: bump tonic from 0.9.1 to 0.9.2 (vectordotdev#17221) [aa9cbd0](answerbook/vector@aa9cbd0) - GitHub * **deps**: bump tonic-build from 0.8.4 to 0.9.2 (vectordotdev#17274) [e0a07c6](answerbook/vector@e0a07c6) - GitHub * **deps**: bump tracing-subscriber from 0.3.16 to 0.3.17 (vectordotdev#17268) [1406c08](answerbook/vector@1406c08) - GitHub * **deps**: bump typetag from 0.2.7 to 0.2.8 (vectordotdev#17302) [c8e0e5f](answerbook/vector@c8e0e5f) - GitHub * **deps**: bump uuid from 1.3.0 to 1.3.1 (vectordotdev#17091) [9cc2f1d](answerbook/vector@9cc2f1d) - GitHub * **deps**: bump uuid from 1.3.0 to 1.3.2 (vectordotdev#17256) [bc6f7fd](answerbook/vector@bc6f7fd) - GitHub * **deps**: bump uuid from 1.3.2 to 1.3.3 (vectordotdev#17403) [3a3fe63](answerbook/vector@3a3fe63) - GitHub * **deps**: bump warp from 0.3.4 to 0.3.5 (vectordotdev#17288) [d8c1f12](answerbook/vector@d8c1f12) - GitHub * **deps**: bump wasm-bindgen from 0.2.84 to 0.2.85 (vectordotdev#17356) [ea24b4d](answerbook/vector@ea24b4d) - GitHub * **deps**: bump wasm-bindgen from 0.2.85 to 0.2.86 (vectordotdev#17402) [0518176](answerbook/vector@0518176) - GitHub * **deps**: bump wiremock from 0.5.17 to 0.5.18 (vectordotdev#17092) [51312aa](answerbook/vector@51312aa) - GitHub * **deps**: Fix up missing license (vectordotdev#17379) [a2b8903](answerbook/vector@a2b8903) - GitHub * **deps**: Reset dependencies bumped by a61dea1 (vectordotdev#17100) [887d6d7](answerbook/vector@887d6d7) - GitHub * **deps**: true up cargo.lock (vectordotdev#17149) [10fce65](answerbook/vector@10fce65) - GitHub * **deps**: Update h2 (vectordotdev#17189) [a2882f3](answerbook/vector@a2882f3) - GitHub * **deps**: Upgrade cue to 0.5.0 (vectordotdev#17204) [d396320](answerbook/vector@d396320) - GitHub * **deps**: Upgrade Debian to bullseye for distroless image (vectordotdev#17160) [c304a8c](answerbook/vector@c304a8c) - GitHub * **deps**: Upgrade rust to 1.69.0 (vectordotdev#17194) [ef15696](answerbook/vector@ef15696) - GitHub * **dev**: Add note about generating licenses to CONTRIBUTING.md (vectordotdev#17410) [539f379](answerbook/vector@539f379) - GitHub * **dev**: ignore `.helix` dir (vectordotdev#17203) [32a935b](answerbook/vector@32a935b) - GitHub * **dev**: Install the correct `mold` based on CPU architecture (vectordotdev#17248) [4b80c71](answerbook/vector@4b80c71) - GitHub * **dev**: remove editors from gitignore (vectordotdev#17267) [61c0d76](answerbook/vector@61c0d76) - GitHub * **docs**: Add Enterprise link and update Support link (vectordotdev#17408) [5184d50](answerbook/vector@5184d50) - GitHub * **docs**: Add missing 0.28.2 version [38607cd](answerbook/vector@38607cd) - Jesse Szwedko * **docs**: Clarify `key_field` for `sample` and `throttle` transforms (vectordotdev#17372) [d1e5588](answerbook/vector@d1e5588) - GitHub * **docs**: Document event type conditions (vectordotdev#17311) [a9c8dc8](answerbook/vector@a9c8dc8) - GitHub * **docs**: make doc style edits (vectordotdev#17155) [65a8856](answerbook/vector@65a8856) - GitHub * **docs**: Remove trailing, unmatched quote (vectordotdev#17163) [3c92556](answerbook/vector@3c92556) - GitHub * **docs**: Remove unneeded `yaml` dependency from website (vectordotdev#17215) [752d424](answerbook/vector@752d424) - GitHub * **docs**: Update component statuses 2023Q2 (vectordotdev#17362) [22cda94](answerbook/vector@22cda94) - GitHub * **docs**: update the `v0.28.0` upgrade guide with note about `datadog_logs` sink `hostname` key (vectordotdev#17156) [c169131](answerbook/vector@c169131) - GitHub * **external docs**: correctly mark some sinks as stateful (vectordotdev#17085) [64d560d](answerbook/vector@64d560d) - GitHub * **loki sink**: warn on label expansions and collisions (vectordotdev#17052) [f06692b](answerbook/vector@f06692b) - GitHub * **pulsar**: pulsar-rs bump to v5.1.1 (vectordotdev#17159) [68b54a9](answerbook/vector@68b54a9) - GitHub * Re-add transform definitions (vectordotdev#17152) [9031d0f](answerbook/vector@9031d0f) - GitHub * Regen docs for sample and throttle (vectordotdev#17390) [6c57ca0](answerbook/vector@6c57ca0) - GitHub * **releasing**: Add known issues fixed by 0.29.1 (vectordotdev#17218) [40d543a](answerbook/vector@40d543a) - GitHub * **releasing**: Bump Vector version to 0.30.0 (vectordotdev#17134) [3834612](answerbook/vector@3834612) - GitHub * **releasing**: Fix homebrew release script (vectordotdev#17131) [cfbf233](answerbook/vector@cfbf233) - Jesse Szwedko * **releasing**: Fix release channels (vectordotdev#17133) [58b44e8](answerbook/vector@58b44e8) - Jesse Szwedko * **releasing**: Prepare v0.28.2 release [a61dea1](answerbook/vector@a61dea1) - Jesse Szwedko * **releasing**: Prepare v0.29.0 release [4bf6805](answerbook/vector@4bf6805) - Jesse Szwedko * **releasing**: Prepare v0.30.0 release [38c3f0b](answerbook/vector@38c3f0b) - Jesse Szwedko * **releasing**: Regenerate Kubernetes manifests for 0.21.2 (vectordotdev#17108) [fd13d64](answerbook/vector@fd13d64) - GitHub * **releasing**: Regenerate manifests for 0.21.1 chart (vectordotdev#17187) [1f0de6b](answerbook/vector@1f0de6b) - GitHub * **releasing**: Regenerate manifests for 0.22.0 chart (vectordotdev#17135) [e7ea0a8](answerbook/vector@e7ea0a8) - GitHub * **releasing**: update patch release template with extra step details [27c3526](answerbook/vector@27c3526) - GitHub * Remove skaffold from project (vectordotdev#17145) [d245927](answerbook/vector@d245927) - GitHub * remove transform type coercion (vectordotdev#17411) [b6c7e0a](answerbook/vector@b6c7e0a) - GitHub * Revert transform definitions (vectordotdev#17146) [05a3f44](answerbook/vector@05a3f44) - GitHub * **socket source**: Remove deprecated `max_length` setting from `tcp` and `unix` modes. (vectordotdev#17162) [9ecfc8c](answerbook/vector@9ecfc8c) - GitHub * **syslog source**: remove the remove of source_ip (vectordotdev#17184) [5dff0ed](answerbook/vector@5dff0ed) - GitHub * **topology**: Transform outputs hash table of OutputId -> Definition (vectordotdev#17059) [1bdb24d](answerbook/vector@1bdb24d) - GitHub * Upgrade `VRL` to `0.3.0` (vectordotdev#17325) [4911d36](answerbook/vector@4911d36) - GitHub ### Features * adds 'metric_name' field to internal logs for the tag_cardinality_limit component (vectordotdev#17295) [4317340](answerbook/vector@4317340) - GitHub * **codecs**: Add full codec support to AWS S3 source/sink (vectordotdev#17098) [d648c86](answerbook/vector@d648c86) - GitHub * **kubernetes_logs**: use kube-apiserver cache for list requests (vectordotdev#17095) [e46fae7](answerbook/vector@e46fae7) - GitHub * Merge with upstream v0.30.0 [6b93177](answerbook/vector@6b93177) - GitHub [LOG-17997](https://logdna.atlassian.net/browse/LOG-17997) * **new sink**: Initial `datadog_events` sink (vectordotdev#7678) [fef3810](answerbook/vector@fef3810) - Jesse Szwedko * Update VRL library [6ace1e6](answerbook/vector@6ace1e6) - Jorge Bay ### Miscellaneous * Merge branch 'master' [d4b35bb](answerbook/vector@d4b35bb) - Jorge Bay * Merge tag 'v0.30.0' into update-upstream [ee2f300](answerbook/vector@ee2f300) - Jorge Bay * Merge commit '9031d0faa2811187874364e1b5a3305c9ed0c0da' into update-upstream [c12faae](answerbook/vector@c12faae) - Jorge Bay * Improve tokio::select behavior for kafka source and finalizers (vectordotdev#17380) [d4df21c](answerbook/vector@d4df21c) - GitHub * Prepare v0.29.1 release [21beed7](answerbook/vector@21beed7) - Kyle Criddle * Add a quickfix to handle special capitalization cases (vectordotdev#17141) [ba63e21](answerbook/vector@ba63e21) - GitHub * Adjust doc comment locations (vectordotdev#17154) [730c938](answerbook/vector@730c938) - GitHub * **amqp sink**: Support AMQ Properties (content-type) in AMQP sink (vectordotdev#17174) [c10d30b](answerbook/vector@c10d30b) - GitHub * **aws provider**: Let `region` be configured for default authentication (vectordotdev#17414) [c81ad30](answerbook/vector@c81ad30) - GitHub * **core**: add unit test (ignored) for support for encoding special chars in `ProxyConfig` (vectordotdev#17148) [5247972](answerbook/vector@5247972) - GitHub * **loki sink**: Fix formatting in labels example (vectordotdev#17396) [f3734e8](answerbook/vector@f3734e8) - GitHub * **observability**: Log underlying error for unhandled HTTP errors (vectordotdev#17327) [bf8376c](answerbook/vector@bf8376c) - GitHub * **observability**: Update internal log rate limiting messages (vectordotdev#17394) [1951535](answerbook/vector@1951535) - GitHub * **pulsar sink**: Refactor to use StreamSink (vectordotdev#14345) [1e97a2f](answerbook/vector@1e97a2f) - GitHub * **topology**: Add source id to metadata (vectordotdev#17369) [c683999](answerbook/vector@c683999) - GitHub * **vdev**: Load compose files and inject network block (vectordotdev#17025) [5d88655](answerbook/vector@5d88655) - GitHub

syedriko requested a review from spencergilbert as a code owner April 27, 2023 04:14

syedriko requested a review from a team April 27, 2023 04:14

github-actions bot added the domain: sinks Anything related to the Vector's sinks label Apr 27, 2023

jszwedko assigned spencergilbert Apr 27, 2023

bruceg added type: bug A code related bug. sink: elasticsearch Anything `elasticsearch` sink related labels Apr 27, 2023

syedriko force-pushed the syedriko_bug_17226 branch 2 times, most recently from 54763e3 to a26bd23 Compare April 27, 2023 21:04

spencergilbert reviewed Apr 28, 2023

View reviewed changes

syedriko force-pushed the syedriko_bug_17226 branch from a26bd23 to 8a336f0 Compare April 29, 2023 02:21

spencergilbert requested changes May 1, 2023

View reviewed changes

src/sinks/elasticsearch/common.rs Outdated Show resolved Hide resolved

src/sinks/elasticsearch/common.rs Outdated Show resolved Hide resolved

syedriko force-pushed the syedriko_bug_17226 branch from 8a336f0 to 80ce4b3 Compare May 1, 2023 19:07

spencergilbert self-requested a review May 1, 2023 19:40

fix(elasticsearch sink): Elasticsearch sink with api_version set to "…

13be8fd

…auto" does not recognize the API version of ES6 as V6 (vectordotdev#17226)

syedriko force-pushed the syedriko_bug_17226 branch from 80ce4b3 to 13be8fd Compare May 1, 2023 20:57

spencergilbert approved these changes May 2, 2023

View reviewed changes

spencergilbert merged commit 9b6ef24 into vectordotdev:master May 2, 2023

syedriko deleted the syedriko_bug_17226 branch May 2, 2023 15:11

spencergilbert mentioned this pull request May 2, 2023

Elasticsearch sink with api_version set to "auto" does not recognize the API version of ES6 as V6 #17226

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(elasticsearch sink): Elasticsearch sink with api_version set to "auto" does not recognize the API version of ES6 as V6 (#17226) #17227

fix(elasticsearch sink): Elasticsearch sink with api_version set to "auto" does not recognize the API version of ES6 as V6 (#17226) #17227

syedriko commented Apr 27, 2023

bits-bot commented Apr 27, 2023 •

edited

Loading

netlify bot commented Apr 27, 2023 •

edited

Loading

netlify bot commented Apr 27, 2023 •

edited

Loading

spencergilbert left a comment

spencergilbert Apr 28, 2023

bruceg Apr 28, 2023

spencergilbert Apr 28, 2023

syedriko Apr 29, 2023

github-actions bot commented May 1, 2023

spencergilbert left a comment

github-actions bot commented May 1, 2023

github-actions bot commented May 1, 2023

spencergilbert left a comment

fix(elasticsearch sink): Elasticsearch sink with api_version set to "auto" does not recognize the API version of ES6 as V6 (#17226) #17227

fix(elasticsearch sink): Elasticsearch sink with api_version set to "auto" does not recognize the API version of ES6 as V6 (#17226) #17227

Conversation

syedriko commented Apr 27, 2023

bits-bot commented Apr 27, 2023 • edited Loading

netlify bot commented Apr 27, 2023 • edited Loading

✅ Deploy Preview for vrl-playground canceled.

netlify bot commented Apr 27, 2023 • edited Loading

✅ Deploy Preview for vector-project canceled.

spencergilbert left a comment

Choose a reason for hiding this comment

spencergilbert Apr 28, 2023

Choose a reason for hiding this comment

bruceg Apr 28, 2023

Choose a reason for hiding this comment

spencergilbert Apr 28, 2023

Choose a reason for hiding this comment

syedriko Apr 29, 2023

Choose a reason for hiding this comment

github-actions bot commented May 1, 2023

Regression Detector Results

spencergilbert left a comment

Choose a reason for hiding this comment

github-actions bot commented May 1, 2023

Regression Detector Results

github-actions bot commented May 1, 2023

Regression Detector Results

spencergilbert left a comment

Choose a reason for hiding this comment

bits-bot commented Apr 27, 2023 •

edited

Loading

netlify bot commented Apr 27, 2023 •

edited

Loading

netlify bot commented Apr 27, 2023 •

edited

Loading