Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): checkout a greater depth in regression workflow #17604

Merged
merged 2 commits into from
Jun 6, 2023
Merged

fix(ci): checkout a greater depth in regression workflow #17604

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4ff557
fix(ci): checkout a greater depth in regression workflow
neuronull Jun 5, 2023
6c4ccb5
don't proceed if metadata not computed
neuronull Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 50 additions & 1 deletion .github/workflows/regression.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,31 @@ jobs:

- uses: actions/checkout@v3

- name: Checkout PR branch (issue_comment)
- name: Checkout PR (issue_comment)
if: github.event_name == 'issue_comment'
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: gh pr checkout ${{ github.event.issue.number }}

- name: Get PR branch name (issue_comment)
id: get-pr-branch-name
if: github.event_name == 'issue_comment'
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
export BRANCH=$(git branch --show-current)
echo "BRANCH=${BRANCH}"
echo "BRANCH=${BRANCH}" >> $GITHUB_OUTPUT

- name: Checkout PR branch (issue_comment)
if: github.event_name == 'issue_comment'
uses: actions/checkout@v3
with:
# TODO: this can be done more elegantly in a follow-up by using a depth value and
# increasing it until the merge-base is found.
fetch-depth: 500
ref: "${{ steps.get-pr-branch-name.outputs.BRANCH }}"

# If triggered by issue comment, the event payload doesn't directly contain the head and base sha from the PR.
# But, we can retrieve this info from some commands.
- name: Get PR metadata (issue_comment)
Expand Down Expand Up @@ -166,6 +185,21 @@ jobs:
echo "comparison sha is: ${COMPARISON_SHA}"
echo "comparison tag is: ${COMPARISON_TAG}"

if [ "${BASELINE_SHA}" = "" ] ; then
echo "BASELINE_SHA not found, exiting."
exit 1
fi

if [ "${COMPARISON_SHA}" = "" ] ; then
echo "COMPARISON_SHA not found, exiting."
exit 1
fi

if [ "${PR_NUMBER}" = "" ] ; then
echo "PR_NUMBER not found, exiting."
exit 1
fi

# If triggered by merge queue, the PR number is not available in the payload. While we restrict the number of PRs in the
# queue to 1, we can get the PR number by parsing the merge queue temp branch's ref.
- name: Get PR metadata (merge queue)
Expand Down Expand Up @@ -195,6 +229,21 @@ jobs:
echo "comparison sha is: ${COMPARISON_SHA}"
echo "comparison tag is: ${COMPARISON_TAG}"

if [ "${BASELINE_SHA}" = "" ] ; then
echo "BASELINE_SHA not found, exiting."
exit 1
fi

if [ "${COMPARISON_SHA}" = "" ] ; then
echo "COMPARISON_SHA not found, exiting."
exit 1
fi

if [ "${PR_NUMBER}" = "" ] ; then
echo "PR_NUMBER not found, exiting."
exit 1
fi

- name: Setup experimental metadata
id: experimental-meta
run: |
Expand Down