Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(datadog_logs sink)!: Use endpoint config setting consistent with the other datadog_ sinks. #18497

Merged
merged 5 commits into from
Sep 14, 2023
Merged

chore(datadog_logs sink)!: Use endpoint config setting consistent with the other datadog_ sinks. #18497

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
831e6dc
chore(docs): clarify endpoint path needed for datadog sinks
neuronull Sep 6, 2023
c0fd6c9
restore
neuronull Sep 11, 2023
543708f
modify dd logs endpoint processing
neuronull Sep 11, 2023
2869ca3
Merge branch 'master' into neuronull/docs_datadog_sink_endpoint_path
neuronull Sep 11, 2023
fd037f5
edit upgrade guide
neuronull Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/sinks/datadog/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@ pub(crate) fn default_site() -> String {
pub struct DatadogCommonConfig {
/// The endpoint to send observability data to.
///
/// The endpoint must contain an HTTP scheme, and may specify a
/// hostname or IP address and port.
/// The endpoint must contain an HTTP scheme, and may specify a hostname or IP
/// address and port. The path must be specified if expected by the downstream.
///
/// If set, overrides the `site` option.
#[configurable(metadata(docs::advanced))]
#[configurable(metadata(docs::examples = "http://127.0.0.1:8080"))]
#[configurable(metadata(docs::examples = "http://example.com:12345"))]
#[configurable(metadata(docs::examples = "http://127.0.0.1:8080/api/v2/logs"))]
#[configurable(metadata(docs::examples = "http://example.com:12345/api/beta/sketches"))]
neuronull marked this conversation as resolved.
Show resolved Hide resolved
#[serde(default)]
pub endpoint: Option<String>,

Expand Down
6 changes: 3 additions & 3 deletions website/cue/reference/components/sinks/base/datadog_events.cue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,13 @@ base: components: sinks: datadog_events: configuration: {
description: """
The endpoint to send observability data to.

The endpoint must contain an HTTP scheme, and may specify a
hostname or IP address and port.
The endpoint must contain an HTTP scheme, and may specify a hostname or IP
address and port. The path must be specified if expected by the downstream.

If set, overrides the `site` option.
"""
required: false
type: string: examples: ["http://127.0.0.1:8080", "http://example.com:12345"]
type: string: examples: ["http://127.0.0.1:8080/api/v2/logs", "http://example.com:12345/api/beta/sketches"]
}
region: {
deprecated: true
Expand Down
6 changes: 3 additions & 3 deletions website/cue/reference/components/sinks/base/datadog_logs.cue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,13 +128,13 @@ base: components: sinks: datadog_logs: configuration: {
description: """
The endpoint to send observability data to.

The endpoint must contain an HTTP scheme, and may specify a
hostname or IP address and port.
The endpoint must contain an HTTP scheme, and may specify a hostname or IP
address and port. The path must be specified if expected by the downstream.

If set, overrides the `site` option.
"""
required: false
type: string: examples: ["http://127.0.0.1:8080", "http://example.com:12345"]
type: string: examples: ["http://127.0.0.1:8080/api/v2/logs", "http://example.com:12345/api/beta/sketches"]
}
region: {
deprecated: true
Expand Down
6 changes: 3 additions & 3 deletions website/cue/reference/components/sinks/base/datadog_metrics.cue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,13 @@ base: components: sinks: datadog_metrics: configuration: {
description: """
The endpoint to send observability data to.

The endpoint must contain an HTTP scheme, and may specify a
hostname or IP address and port.
The endpoint must contain an HTTP scheme, and may specify a hostname or IP
address and port. The path must be specified if expected by the downstream.

If set, overrides the `site` option.
"""
required: false
type: string: examples: ["http://127.0.0.1:8080", "http://example.com:12345"]
type: string: examples: ["http://127.0.0.1:8080/api/v2/logs", "http://example.com:12345/api/beta/sketches"]
}
region: {
deprecated: true
Expand Down
6 changes: 3 additions & 3 deletions website/cue/reference/components/sinks/base/datadog_traces.cue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,13 @@ base: components: sinks: datadog_traces: configuration: {
description: """
The endpoint to send observability data to.

The endpoint must contain an HTTP scheme, and may specify a
hostname or IP address and port.
The endpoint must contain an HTTP scheme, and may specify a hostname or IP
address and port. The path must be specified if expected by the downstream.

If set, overrides the `site` option.
"""
required: false
type: string: examples: ["http://127.0.0.1:8080", "http://example.com:12345"]
type: string: examples: ["http://127.0.0.1:8080/api/v2/logs", "http://example.com:12345/api/beta/sketches"]
}
request: {
description: """
Expand Down