Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(websites): Setup preview site workflows #18924
chore(websites): Setup preview site workflows #18924
Changes from 3 commits
c4a083c
e2de3d3
4c242bf
904af25
51b24e5
eda2588
610d353
a671681
ab48faa
36c5fbf
07578a1
0151918
8577084
22eb7cf
df636b9
38d47af
2a47dd9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will
github.head_ref
work here? I'm not actually sure what ref it might refer to in this context (maybe master?). I would think you might need to thread the PR git ref through from the "Call Build Preview" via build artifacts (similar to what is described on https://securitylab.github.com/research/github-actions-preventing-pwn-requests/).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, I don't know that
github.event.pull_request.number
will be populated. You may need to thread it through from the PR-triggered workflow as a build artifact.