Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Reinstall rustup in MacOS bootstrap #20911

Merged
merged 6 commits into from
Jul 23, 2024

Conversation

jszwedko
Copy link
Member

@jszwedko jszwedko commented Jul 22, 2024

The package was renamed from rustup-init to rustup which seems to be causing some issues in CI where the package is already installed (because rustup-init was renamed to it) but rustup doesn't have the actual rustup binaries downloaded. Reinstalling seems to fix this.

The package was renamed from rustup-init to rustup which seems to be causing some issues in CI.

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jul 22, 2024
@github-actions github-actions bot added the domain: ci Anything related to Vector's CI environment label Jul 22, 2024
@jszwedko
Copy link
Member Author

/ci-run-unit-mac

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@jszwedko
Copy link
Member Author

/ci-run-unit-mac

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@@ -48,6 +49,8 @@
${{ runner.os }}-cargo-

- run: bash scripts/environment/bootstrap-macos-10.sh
- name: Setup tmate session

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

tmate is not a recognized word. (unrecognized-spelling)
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@@ -12,6 +12,12 @@

brew install ruby@3 coreutils cue-lang/tap/cue protobuf

# rustup-init (renamed to rustup) is preinstalled on CI, but seems to be lacking the rustup binary

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

preinstalled is not a recognized word. (unrecognized-spelling)
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@jszwedko jszwedko changed the title chore(ci): Install rustup in MacOS bootstrap chore(ci): Reinstall rustup in MacOS bootstrap Jul 22, 2024
@jszwedko jszwedko marked this pull request as ready for review July 22, 2024 21:11
@jszwedko jszwedko enabled auto-merge July 22, 2024 21:35
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: jszwedko/fix-macos-bootstrap
Commit report: c051dba
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.44s Total Time

@jszwedko jszwedko added this pull request to the merge queue Jul 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 22, 2024
@jszwedko jszwedko added this pull request to the merge queue Jul 23, 2024
Copy link

Regression Detector Results

Run ID: fd08c314-74a1-4e71-ad47-84996d1a2c29 Metrics dashboard

Baseline: 67a5e46
Comparison: 3b6a738

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI links
file_to_blackhole egress throughput -7.81 [-14.47, -1.16]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
syslog_humio_logs ingress throughput +2.93 [+2.80, +3.06]
splunk_hec_route_s3 ingress throughput +2.13 [+1.83, +2.44]
http_text_to_http_json ingress throughput +1.95 [+1.83, +2.07]
syslog_log2metric_humio_metrics ingress throughput +1.07 [+0.92, +1.22]
datadog_agent_remap_blackhole ingress throughput +0.79 [+0.68, +0.90]
syslog_loki ingress throughput +0.72 [+0.64, +0.80]
datadog_agent_remap_datadog_logs ingress throughput +0.48 [+0.28, +0.69]
otlp_http_to_blackhole ingress throughput +0.30 [+0.13, +0.47]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.01 [-0.12, +0.13]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.08, +0.08]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.01 [-0.11, +0.10]
http_to_http_json ingress throughput -0.06 [-0.16, +0.03]
datadog_agent_remap_blackhole_acks ingress throughput -0.10 [-0.23, +0.03]
http_to_http_noack ingress throughput -0.12 [-0.23, -0.00]
syslog_splunk_hec_logs ingress throughput -0.37 [-0.48, -0.26]
fluent_elasticsearch ingress throughput -0.45 [-0.96, +0.06]
socket_to_socket_blackhole ingress throughput -0.58 [-0.64, -0.52]
otlp_grpc_to_blackhole ingress throughput -0.61 [-0.74, -0.48]
http_to_http_acks ingress throughput -0.71 [-2.02, +0.61]
http_to_s3 ingress throughput -0.75 [-1.02, -0.49]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -0.90 [-0.99, -0.81]
http_elasticsearch ingress throughput -1.08 [-1.24, -0.92]
syslog_log2metric_splunk_hec_metrics ingress throughput -1.30 [-1.43, -1.17]
syslog_regex_logs2metric_ddmetrics ingress throughput -2.01 [-2.23, -1.78]
datadog_agent_remap_datadog_logs_acks ingress throughput -2.16 [-2.34, -1.98]
file_to_blackhole egress throughput -7.81 [-14.47, -1.16]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into master with commit 3b6a738 Jul 23, 2024
50 checks passed
@jszwedko jszwedko deleted the jszwedko/fix-macos-bootstrap branch July 23, 2024 02:35
ym pushed a commit to ym/vector that referenced this pull request Aug 18, 2024
* chore(ci): Install rustup in MacOS bootstrap

The package was renamed from rustup-init to rustup which seems to be causing some issues in CI.

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

* Ensure rustup in PATH

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

* debug

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

* Reinstall rustup

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

* Actually reinstall

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

* Remove pr trigger

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

---------

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
* chore(ci): Install rustup in MacOS bootstrap

The package was renamed from rustup-init to rustup which seems to be causing some issues in CI.

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

* Ensure rustup in PATH

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

* debug

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

* Reinstall rustup

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

* Actually reinstall

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

* Remove pr trigger

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

---------

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: ci Anything related to Vector's CI environment no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants